D14041: Honor ghns KIOSK restriction in new KCMs

2018-07-11 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4e2a515bb34f: Honor ghns KIOSK restriction in new KCMs 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14041?vs=37548=37556

REVISION DETAIL
  https://phabricator.kde.org/D14041

AFFECTED FILES
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14041: Honor ghns KIOSK restriction in new KCMs

2018-07-11 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:147
> What does kcm.canInstall do?

// Disable the install button if we can't install new themes to ~/.icons,
  // or Xcursor isn't set up to look for cursor themes there.
  if (!m_model->searchPaths().contains(QDir::homePath() + "/.icons") || 
!iconsIsWritable()) {
  setCanInstall(false);
  }

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14041

To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14041: Honor ghns KIOSK restriction in new KCMs

2018-07-11 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> main.qml:147
>  onClicked: kcm.getNewClicked();
>  enabled: kcm.canInstall
> +visible: KAuthorized.authorize("ghns")

What does kcm.canInstall do?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14041

To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14041: Honor ghns KIOSK restriction in new KCMs

2018-07-11 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  5.13 branch
  Put the following in `kdeglobals`
  
[KDE Action Restrictions]
ghns=false
  
  and the GHNS buttons were gone. If there are no buttons in the footer, it 
also fully collapses rather than leaving an empty gap at the bottom which is 
nice

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14041

AFFECTED FILES
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml

To: broulik, #plasma, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart