D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. In D14064#322643 , @davidedmundson wrote: > Urgh. Just read the code. > > We don't reset when we type a new letter. To do so would have a jumpy ui. Instead we reset when we get results back. > > That leaves a prob

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

davidedmundson added a comment. Urgh. Just read the code. We don't reset when we type a new letter. To do so would have a jumpy ui. Instead we reset when we get results back. That leaves a problem when you search for "firefo" ( with 1 result) to "firefodfhhxtffrdh" with zero results

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. No point pinging if we haven't replied to Kai's comments/question. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14064 To: McPain, brouli

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

acrouthamel added a comment. Any movement on this? It would be great to use the dictionary in krunner. Still broken in 5.13.4. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14064 To: McPain, broulik Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, le

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. ping? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14064 To: McPain, broulik Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. In D14064#291125 , @broulik wrote: > I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I d

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

broulik added a comment. I would rather see a thorough investigation on what this does and why it is or is not needed. There's a couple of slow runners that suffer issues because of premature resetting but I don't understand why it has this code in the first place. REPOSITORY R112 Milou

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

ngraham added a comment. Thanks for the patch! It will be nice to get the Dictionary runner working again. Please change `https://bugs.kde.org/show_bug.cgi?id=390776` to `CCBUG: 390776`. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords REPOSITORY R112 Mil