D14250: Sort update items by completion

2018-07-25 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:42083fa8ac72: Sort update items by completion (authored 
by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14250?vs=38142&id=38413

REVISION DETAIL
  https://phabricator.kde.org/D14250

AFFECTED FILES
  discover/qml/UpdatesPage.qml
  libdiscover/UpdateModel/UpdateItem.h
  libdiscover/UpdateModel/UpdateModel.cpp
  libdiscover/UpdateModel/UpdateModel.h

To: apol, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14250: Sort update items by completion

2018-07-24 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Sorry for the long delay in reviewing. I gave this a shot with a huge batch 
of 400 updates on Neon. It was a //huge// improvement in user experience. It's 
hard to express how much better Discover felt during the process. Somehow I 
felt more in control (a completely illusory feeling, of course) and more aware 
of what Discover was doing (not at all illusory). Even without animations, it's 
still fantastic. Strong +1.
  
  I think if we can also get https://bugs.kde.org/show_bug.cgi?id=396140, users 
are going to suddenly love using Discover to perform their updates!

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14250

To: apol, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D14250: Sort update items by completion

2018-07-20 Thread Aleix Pol Gonzalez
apol created this revision.
apol added a reviewer: ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Sort update items by completion.
  
  BUG: 390911

TEST PLAN
  Tested locally with dummy and packagekit@alpm (because I already had the rest 
up to date, needs more testing)

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14250

AFFECTED FILES
  discover/qml/UpdatesPage.qml
  libdiscover/UpdateModel/UpdateItem.h
  libdiscover/UpdateModel/UpdateModel.cpp
  libdiscover/UpdateModel/UpdateModel.h

To: apol, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart