D14335: Make astronomical Plasma plugin JSON consistent with other plugins and translatable
kossebau added a comment. TD;LR current legacy-based implementation might need that format. Needs complete tested porting to KPlugin. I had blindly copying the only other-known-to-me existing plugin data, which also has that metadata schema. Cmp. also https://phabricator.kde.org/source/plasma-workspace/browse/master/plasmacalendarintegration/holidayeventsplugin.json Looking at https://phabricator.kde.org/source/plasma-framework/browse/master/src/declarativeimports/calendar/eventpluginsmanager.cpp$136 I see now that this is some legacy schema, and one could also use kplugin-based metadata. Might need some other changes to the plugin, like changing the IID. Can have a look later this week. But grepping for *.json makes my MIME/Media type heart bleed. Someone(tm) should introduce a proper file suffix (e.g. .kplugindata) for those specific schema. We also use .cpp for C++ sources, despite the base format being plain text (.txt). REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14335 To: yurchor, #plasma, #localization, kossebau Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14335: Make astronomical Plasma plugin JSON consistent with other plugins and translatable
ltoscano added a comment. Adding @kossebau with the question: is there a reason to not have the KPlugin key in the json file? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14335 To: yurchor, #plasma, #localization, kossebau Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14335: Make astronomical Plasma plugin JSON consistent with other plugins and translatable
yurchor created this revision. yurchor added reviewers: Plasma, Localization. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY Currently, JSON file has a structure which is not parsed by the scripty. The patch tries to fix this. TEST PLAN 1. Use of "python /createjsoncontext.py `find . -name \*.json` ./po" where is a clone of this dir: https://websvn.kde.org/trunk/l10n-kf5/scripts/ should extract messages from astronomicaleventsplugin.json (tested) 2. The plugin should work (not tested) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14335 AFFECTED FILES plasmacalendarplugins/astronomical/astronomicaleventsplugin.json To: yurchor, #plasma, #localization Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
