D14361: Remove unused function

2018-07-27 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes. Closed by commit R104:ed42cf46ae2c: Remove unused function (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14361?vs=38404=38586 REVISION DETAIL

D14361: Remove unused function

2018-07-27 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Can this cause trouble with ABI since this class is exported? But it's probably just exported as an entry point for KDED and not for use as a library ABI changing is

D14361: Remove unused function

2018-07-26 Thread Frederik Gladhorn
gladhorn added inline comments. INLINE COMMENTS > broulik wrote in daemon.h:38 > Can this cause trouble with ABI since this class is exported? But it's > probably just exported as an entry point for KDED and not for use as a library Well, the header is not installed, so the export seems pretty

D14361: Remove unused function

2018-07-25 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > daemon.h:38 > > class Q_DECL_EXPORT KScreenDaemon : public KDEDModule > { Can this cause trouble with ABI since this class is exported? But it's probably just exported as an entry point for KDED and not for use as a library REPOSITORY

D14361: Remove unused function

2018-07-25 Thread Frederik Gladhorn
gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL