D14362: Use unpretty channel name in speakertest
This revision was automatically updated to reflect the committed changes. Closed by commit R115:7cd16db35a49: Use unpretty channel name in speakertest (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14362?vs=38406&id=41507 REVISION DETAIL https://phabricator.kde.org/D14362 AFFECTED FILES src/kcm/package/contents/ui/Advanced.qml src/sink.cpp src/sink.h src/volumeobject.cpp src/volumeobject.h To: nicolasfella, drosca, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14362: Use unpretty channel name in speakertest
nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in sink.cpp:100 > Can you check this is still correct? It doesn't seem to play any sounds here front-left/front-right work for me. Rest is untested because I don't have such fancy hardware. Just to be sure: Is your sink unmuted/loud enough, correct profile selected? Can you replace name with "front-left-of-center" and test again? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14362 To: nicolasfella, drosca, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14362: Use unpretty channel name in speakertest
broulik added inline comments. INLINE COMMENTS > sink.cpp:100 > ca_proplist_sets(proplist, CA_PROP_MEDIA_ROLE, "test"); > ca_proplist_sets(proplist, CA_PROP_MEDIA_NAME, > name.toLatin1().constData()); > +ca_proplist_sets(proplist, CA_PROP_CANBERRA_FORCE_CHANNEL, > name.toLatin1().data()); Can you check this is still correct? It doesn't seem to play any sounds here REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14362 To: nicolasfella, drosca, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D14362: Use unpretty channel name in speakertest
nicolasfella created this revision. nicolasfella added reviewers: drosca, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The speaker test did not work when channel names were translated, e.g. "Front Left" => "Vorne Links" because the comparison failed. Using pa_channel_position_to_string instead of pa_channel_position_to_pretty_string hopefully works better. REPOSITORY R115 Plasma Audio Volume Applet BRANCH fixspeakertest REVISION DETAIL https://phabricator.kde.org/D14362 AFFECTED FILES src/kcm/package/contents/ui/Advanced.qml src/sink.cpp src/sink.h src/volumeobject.cpp src/volumeobject.h To: nicolasfella, drosca, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
