D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  I'd prefer some dimmed label next to the app name but with the radio button 
and manual size calculations all over the place now, this is difficult

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: alexde, gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, 
abetts, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D15418: Dim application icon when it is not playing anything

[George Vogiatzis]

gvgeo added a comment.


  In D15418#604205 , @alexde wrote:
  
  > ...what about adding an overlay pause-icon, similar to D3302 
?...
  
  
  This could be interpreted as a button.
  
  Not that we removed the audiostream description, can add a message to the 
right ` (No output)`
  
  Although I like none of these two. I prefer simply dimming the label.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: alexde, gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, 
abetts, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D15418: Dim application icon when it is not playing anything

[Alex Debus]

alexde added a comment.


  In D15418#604200 , @broulik wrote:
  
  > > Can't we dim label instead?
  >
  > I quite like that. Also not very obvious what it means, I guess..
  
  
  Not sure if it was already discussed, but what about adding an overlay 
mute-icon, similar to D3302 ? Maybe this is 
easier to understand?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: alexde, gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, 
abetts, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik added a comment.


  > Can't we dim label instead?
  
  I quite like that

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D15418: Dim application icon when it is not playing anything

[Nathaniel Graham]

ngraham added a comment.


  @broulik Ping. :)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D15418: Dim application icon when it is not playing anything

[George Vogiatzis]

gvgeo added a comment.


  In D15418#331397 , @ngraham wrote:
  
  > Maybe something like this?
  >
  > F6283615: Screenshot_20180924_195355.png 

  
  
  This feels too much. There is no need to be so obvious, just need to be able 
to differentiate when there are multiple streams.
  
  Can't we dim label instead? It easier to distinguish with other labels, as 
they have the same color.
  F7880609: Screenshot_20200113_130855.png 
 F7880611: Screenshot_20200113_130816.png 

  
  This is with opacity 0.6. It could be more obvious with 0.55 or 0.5.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, 
ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D15418: Dim application icon when it is not playing anything

[Squeaky Pancakes]

squeakypancakes added a comment.


  Could we just group them like we do on the devices tab?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, ngraham, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik added a comment.


  Not a huge fan of this giant gap tbh

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D15418: Dim application icon when it is not playing anything

[Méven Car]

meven added a comment.


  In D15418#452214 , @meven wrote:
  
  > In D15418#364811 , @mart wrote:
  >
  > > In D15418#331397 , @ngraham 
wrote:
  > >
  > > > Maybe something like this?
  > > >
  > > > F6283615: Screenshot_20180924_195355.png 

  > >
  > >
  > > I like this way
  >
  >
  > Friendly ping ;)
  
  
  I could take over @broulik if you'd prefer.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D15418: Dim application icon when it is not playing anything

[Méven Car]

meven added a comment.


  In D15418#364811 , @mart wrote:
  
  > In D15418#331397 , @ngraham 
wrote:
  >
  > > Maybe something like this?
  > >
  > > F6283615: Screenshot_20180924_195355.png 

  >
  >
  > I like this way
  
  
  Friendly ping ;)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D15418: Dim application icon when it is not playing anything

[Marco Martin]

mart added a comment.


  In D15418#331397 , @ngraham wrote:
  
  > Maybe something like this?
  >
  > F6283615: Screenshot_20180924_195355.png 

  
  
  I like this way

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D15418: Dim application icon when it is not playing anything

[Nathaniel Graham]

ngraham added a comment.


  Maybe something like this?
  
  F6283615: Screenshot_20180924_195355.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: svenmauch, acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Sven Mauch]

svenmauch added a comment.


  Ideally the volume lines would show how loud an application currently is by 
having an equalizer-like overlay on the blue volume bar.
  
  For now I think having the icons with less transparency is confusing. At 
least for me it doesn't seem intuitive enough what it means and it might open 
up possibilites where some icons look weird when dimmed.
  
  Adding icons to all apps that are currently not playing would clutter things 
up since there's usually more apps open that are not playing anything than 
vice-versa.
  
  I thought about adding another volume icon to the bottom-right side of the 
app icons but that would probably look weird right next to the other volume 
icon. Maybe someone can come up with a better idea?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: svenmauch, acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15418#325344 , @broulik wrote:
  
  > All of that is reserved for being "Muted". Just because it doesn't play 
something doesn't mean it couldn't start producing sound any moment.
  >  We shouldn't use anything that could be confused as "muted" ("can never 
make any sound") for "not playing //currently//"
  
  
  How about using `audio-volume-low`? Maybe drop opacity to 50%?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Andres Betts]

abetts added a comment.


  In D15418#325344 , @broulik wrote:
  
  > All of that is reserved for being "Muted". Just because it doesn't play 
something doesn't mean it couldn't start producing sound any moment.
  >  We shouldn't use anything that could be confused as "muted" ("can never 
make any sound") for "not playing //currently//"
  
  
  I see what you mean, I thought we had a "muted" icon. The volume icon with a 
slash in the middle.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik added a comment.


  All of that is reserved for being "Muted". Just because it doesn't play 
something doesn't mean it couldn't start producing sound any moment.
  We shouldn't use anything that could be confused as "muted" ("can never make 
any sound") for "not playing //currently//"

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Nathaniel Graham]

ngraham added a comment.


  In D15418#325341 , @abetts wrote:
  
  > In D15418#325340 , @acrouthamel 
wrote:
  >
  > > How about changing the volume icon for the non-playing application to 
`audio-volume-muted.svg`? Then, when it is playing audio, it reverts to 
low/high icons as usual, based on slider location.
  >
  >
  > Additional to that, the volume slider colors can be grayed out when not 
playing?
  
  
  That happens already when the stream is muted, so we can't re-use the effect 
for this.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Andres Betts]

abetts added a comment.


  In D15418#325340 , @acrouthamel 
wrote:
  
  > How about changing the volume icon for the non-playing application to 
`audio-volume-muted.svg`? Then, when it is playing audio, it reverts to 
low/high icons as usual, based on slider location.
  
  
  Additional to that, the volume slider colors can be grayed out when not 
playing?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Andrew Crouthamel]

acrouthamel added a comment.


  How about changing the volume icon for the non-playing application to 
`audio-volume-muted.svg`? Then, when it is playing audio, it reverts to 
low/high icons as usual, based on slider location.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Nathaniel Graham]

ngraham added a comment.


  Basically +1 on the concept, but I think we need to make the appearance a bit 
more distinct between playing vs non-playing. I've thrown out some ideas, and 
I'm open to others. Reducing the opacity even further would work. Adding a 
little tiny piece of text that says "Not currently playing" to the right  of 
the app name could work too, especially in conjunction with the reduced opacity.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Andrew Crouthamel]

acrouthamel added a comment.


  I like it. I agree though to maybe make them a bit lighter.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Nathaniel Graham]

ngraham added a comment.


  Hmm. Here's another idea: we could badge the app icon with 
`player-volume-muted`, maybe.
  
  I just worry a bit that lightening the app icon may be too subtle, and people 
might see it as a bug or wonder why it looks different.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik added a comment.


  F6252135: Screenshot_20180911_144651.png 

  Fading the mute button doesn't make that big of a diference

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik added a comment.


  We need to take care to not make it confusing with the "muted" state where it 
fades the slider

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Nathaniel Graham]

ngraham added a comment.


  That dimming effect might be too subtle on a brightly colored app icon. How 
about dimming the black volume icon instead of or in addition to the app icon?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When a stream is present but not playing anything ("corked"), show icon 
slightly translucent
  
  BUG: 398476
  FIXED-IN: 5.14.0

TEST PLAN
  VLC is playing, Chrome has a paused video open
  F6251873: Screenshot_20180911_131535.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart