D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Vlad Zagorodniy]

zzag added a comment.


  I'll backport it to Plasma/5.15.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16093

To: Zren, davidedmundson, ngraham
Cc: zzag, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Nathaniel Graham]

ngraham added a comment.


  Yay! Now onto https://bugs.kde.org/show_bug.cgi?id=308331! I tried with 
D16897  but ran into some trouble. It 
works, but the keys are hardcoded rather than reading the key from the global 
shortcuts. What's tricky is that only the key itself should do it, not the key 
plus the modifier (since the user is already holding down a modifier to keep 
the alt-tab switcher open).

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16093

To: Zren, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:80bd32b12a01: Consistent arrow key handling in the 
Informative Alt+Tab skin (authored by Zren).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16093?vs=43263=49829

REVISION DETAIL
  https://phabricator.kde.org/D16093

AFFECTED FILES
  windowswitchers/informative/contents/ui/main.qml

To: Zren, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Yeah, I was probably doing something dumb. Confirmed that this works with 
your test plan.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16093

To: Zren, davidedmundson, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Chris Holland]

Zren added a comment.


  I forgot to merge this after david's patch was merged. I just tested this in 
the Neon Beta ISO to confirm the fix still works.
  
  In D16093#359639 , @ngraham wrote:
  
  > Hmm, this does not actually work for me. Seems like it logically should, 
but it doesn't.
  
  
  I'm guessing you didn't restart the `kwin_x11 --replace` process after 
manually patching the qml file, as I believe the old version is still kwin's 
cache/memory. Changing to another skin and back won't reload the skin, you need 
to restart kwin. That or you tested without D16693 
 that forwards keyboard events to the qml 
skin.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16093

To: Zren, davidedmundson
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

[Nathaniel Graham]

ngraham added a comment.


  Hmm, this does not actually work for me. Seems like it logically should, but 
it doesn't.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16093

To: Zren, davidedmundson
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart