D16651: Honor flat property of buttons

2018-11-13 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8c1fb20f52a5: Honor flat property of buttons (authored by 
astippich).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16651?vs=44934&id=45422

REVISION DETAIL
  https://phabricator.kde.org/D16651

AFFECTED FILES
  org.kde.desktop/Button.qml
  plugin/kquickstyleitem.cpp

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16651: Honor flat property of buttons

2018-11-13 Thread Alexander Stippich 
astippich added a comment.


  friendly ping

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16651

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16651: Honor flat property of buttons

2018-11-05 Thread Alexander Stippich 
astippich marked an inline comment as done.
astippich added a comment.


  How can I actually run this test?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16651

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16651: Honor flat property of buttons

2018-11-05 Thread Alexander Stippich 
astippich updated this revision to Diff 44934.
astippich added a comment.


  - do not unnecessarily check flat property

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16651?vs=44800&id=44934

BRANCH
  flat

REVISION DETAIL
  https://phabricator.kde.org/D16651

AFFECTED FILES
  org.kde.desktop/Button.qml
  plugin/kquickstyleitem.cpp

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16651: Honor flat property of buttons

2018-11-04 Thread Aleix Pol Gonzalez 
apol added a comment.


  Looks good overall.
  
  Maybe it would make sense to add a test in `tests/buttonIcons.qml`?

INLINE COMMENTS

> Button.qml:63
> +"iconColor": controlRoot.icon && controlRoot.icon.color.a > 0? 
> controlRoot.icon.color : Kirigami.Theme.textColor,
> +"flat": controlRoot.flat ? controlRoot.flat : false
>  }

No need to check for `controlRoot.flat` twice

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16651

To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart