D16776: Better error handling in KNewStuff backend

2018-11-13 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R134:7f6caf385809: Better error handling in KNewStuff backend (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16776?vs=45355=45398

D16776: Better error handling in KNewStuff backend

2018-11-12 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D16776 To: leinir, #discover_software_store, apol Cc: plasma-devel, masilva, ragreen, ixoos,

D16776: Better error handling in KNewStuff backend

2018-11-12 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 45355. leinir marked 2 inline comments as done. leinir added a comment. Address @apol's comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16776?vs=45166=45355 REVISION DETAIL

D16776: Better error handling in KNewStuff backend

2018-11-12 Thread Dan Leinir Turthra Jensen
leinir marked 2 inline comments as done. leinir added a comment. In D16776#356741 , @apol wrote: > Where will the `All categories are missing` error fall right now? That is a configuration file error (which is the case, unless there's a

D16776: Better error handling in KNewStuff backend

2018-11-09 Thread Aleix Pol Gonzalez
apol added a comment. Where will the `All categories are missing` error fall right now? INLINE COMMENTS > KNSBackend.cpp:247 > +QString error = message; > +bool invalidFile = false; > +switch(errorCode) { Maybe at least qDebug() it? > KNSBackend.cpp:275 > +case

D16776: Better error handling in KNewStuff backend

2018-11-09 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added reviewers: Discover Software Store, apol. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Previously error handling was