D16844: [comic] Correct usage of DataEngineConsumer

2018-11-25 Thread Anthony Fieroni 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:0f79d76cf932: [comic] Correct usage of DataEngineConsumer 
(authored by anthonyfieroni).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16844?vs=45370=46205

REVISION DETAIL
  https://phabricator.kde.org/D16844

AFFECTED FILES
  applets/comic/comic.cpp

To: anthonyfieroni, #plasma, davidedmundson, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16844: [comic] Correct usage of DataEngineConsumer

2018-11-12 Thread Anthony Fieroni 
anthonyfieroni updated this revision to Diff 45370.
anthonyfieroni added a comment.


  Fix diff

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16844?vs=45369=45370

REVISION DETAIL
  https://phabricator.kde.org/D16844

AFFECTED FILES
  applets/comic/comic.cpp

To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16844: [comic] Correct usage of DataEngineConsumer

2018-11-12 Thread Anthony Fieroni 
anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  Comic applet is DataEngineConsumer which take care of loading / unloading 
engine.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D16844

AFFECTED FILES
  applets/comic/comic.cpp
  dataengines/comic/comicproviderwrapper.cpp

To: anthonyfieroni, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart