D16987: Recalculate connected hash only on change and emit signal

2018-11-18 Thread Roman Gilg
romangg added a comment.


  Checking the edid is necessary, because it might be set asynchronously and 
before that the hash is based on the output name only.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D16987

To: romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D16987: Recalculate connected hash only on change and emit signal

2018-11-18 Thread Roman Gilg
romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Instead of recomputing the connected outputs hash on every access, store
  it in Config and only recalculate it on a change of one of its inputs.
  
  Also inform consumers about the change via a separate signal.

TEST PLAN
  Autotest extended.

REPOSITORY
  R110 KScreen Library

BRANCH
  configConnectedOutputsHashChanged

REVISION DETAIL
  https://phabricator.kde.org/D16987

AFFECTED FILES
  autotests/testscreenconfig.cpp
  src/config.cpp
  src/config.h
  src/output.cpp
  src/output.h

To: romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart