D18596: Set combobox popups to be modal

2019-02-01 Thread Nathaniel Graham 
ngraham added a comment.


  After living with this for a few days, I notice that now the behavior is 
reversed: clicking anywhere else will close but pop-up, but clicking on the 
button will not!

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18596

To: davidedmundson, #plasma, ngraham
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18596: Set combobox popups to be modal

2019-02-01 Thread Kai Uwe Broulik 
broulik added a comment.


  It's still a bit weird that the closing of combobox popups fails to function 
in embedded view like System Settings. Still +1 as this makes the behavior 
consistent with what we have on X elsewhere.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18596

To: davidedmundson, #plasma, ngraham
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18596: Set combobox popups to be modal

2019-01-29 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:0ac99af6e691: Set combobox popups to be modal (authored 
by davidedmundson).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18596?vs=50483&id=50489

REVISION DETAIL
  https://phabricator.kde.org/D18596

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: davidedmundson, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18596: Set combobox popups to be modal

2019-01-29 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This closer matches what we see on QWidgets where losing focus closes
  the combobox.
  
  BUG: 403403

TEST PLAN
  Opened a combobox
  Clicked outside
  It closed

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18596

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart