D18814: Clarify the label of the Shell KRunner.

[Valerio Pilo]

vpilo abandoned this revision.
vpilo added a comment.


  In D18814#407090 , @davidedmundson 
wrote:
  
  > What problem are we solving?
  >
  > If someone said "in a shell" I would expect to see a terminal (a shell) 
appear. That's not the case.
  
  
  I thought an inexperienced user could be helped by a more precise outlining 
of the result.
  
  In D18814#407087 , @ngraham wrote:
  
  > By making this label long, the available room for the command itself is 
correspondingly reduced, and this UI already has a limited amount of horizontal 
space. It's probably worse for other languages.
  >
  > I think the current string is fine given that it says "Command line" to the 
left.
  
  
  Fair enough.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  By making this label long, the available room for the command itself is 
correspondingly reduced, and this UI already has a limited amount of horizontal 
space. It's probably worse for other languages.
  
  I think the current string is fine given that it says "Command line" to the 
left.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[David Edmundson]

davidedmundson added a comment.


  What problem are we solving?
  
  If someone said "in a shell" I would expect to see a terminal (a shell) 
appear. That's not the case.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[Valerio Pilo]

vpilo added a comment.


  In D18814#407083 , @davidedmundson 
wrote:
  
  > It already says "Command line" in the group title on the left a console 
icon and unlike apps has the prefix "Run "
  
  
  "Run %1 in a shell" then?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[David Edmundson]

davidedmundson added a comment.


  It already says "Command line" in the group title on the left a console icon 
and unlike apps has the prefix "Run "

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18814

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18814: Clarify the label of the Shell KRunner.

[Valerio Pilo]

vpilo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  This makes sure the end result of the consequence of clicking this runner's 
results (running a shell command).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  vpilo/clarifyKRunnerShell (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18814

AFFECTED FILES
  runners/shell/shellrunner.cpp

To: vpilo
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart