D19654: Add lazy instantiation for submenus

2019-03-11 Thread Andreas Cord-Landwehr 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d06e7280045d: Add lazy instantiation for submenus 
(authored by cordlandwehr).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19654?vs=53596&id=53688

REVISION DETAIL
  https://phabricator.kde.org/D19654

AFFECTED FILES
  src/controls/private/ActionsMenu.qml

To: cordlandwehr, apol, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19654: Add lazy instantiation for submenus

2019-03-10 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Actually let's get this in and see how it works.

REPOSITORY
  R169 Kirigami

BRANCH
  lazyGenerationOfMenus

REVISION DETAIL
  https://phabricator.kde.org/D19654

To: cordlandwehr, apol, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19654: Add lazy instantiation for submenus

2019-03-10 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19654

To: cordlandwehr, apol, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D19654: Add lazy instantiation for submenus

2019-03-10 Thread Andreas Cord-Landwehr 
cordlandwehr created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Items of submenus are only required when the respective submenu is
  becoming visible. Setting the intantiator to active only when the
  menu is visible avoids loading all submenus at once.

REPOSITORY
  R169 Kirigami

BRANCH
  lazyGenerationOfMenus

REVISION DETAIL
  https://phabricator.kde.org/D19654

AFFECTED FILES
  src/controls/private/ActionsMenu.qml

To: cordlandwehr
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein