D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:da0adfedcab0: Make location of "Lock Widgets" 
and "Remove Panel" buttons more obvious (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20144?vs=55225&id=55352

REVISION DETAIL
  https://phabricator.kde.org/D20144

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: ndavis, abetts, filipf, rooty, ngraham, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg, ngraham
Cc: ndavis, abetts, filipf, rooty, ngraham, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All right, all right, let's go with the separator. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg, ngraham
Cc: ndavis, abetts, filipf, rooty, ngraham, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Filip Fila]

filipf added a comment.


  In D20144#442451 , @GB_2 wrote:
  
  > In D20144#441802 , @ngraham 
wrote:
  >
  > > Hmm, the separator line feels like a bit much to me. How about just 
`units.largeSpacing` or `units.gridUnit` between them?
  >
  >
  > This is it without separator, I personally think it looks weird with that 
gap: F6746651: More Obvious Location of Lock Widgets and Remove Panel Buttons 
(Vertical) (No Separator).png 
  >  Let's see what others think.
  
  
  +1 for the idea of the patch
  
  Gap -  looks weird to me as well
  
  Separator - it's okay IMO
  
  If we really wanted to be sure we could have a confirmation dialog for 
deleting the panel, although the Undo button you get in a notification somewhat 
lessens the need for it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, filipf, rooty, ngraham, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Björn Feber]

GB_2 added subscribers: rooty, filipf, abetts, ndavis.
GB_2 added a comment.


  In D20144#441802 , @ngraham wrote:
  
  > Hmm, the separator line feels like a bit much to me. How about just 
`units.largeSpacing` or `units.gridUnit` between them?
  
  
  This is it without separator, I personally think it looks weird with that 
gap: F6746651: More Obvious Location of Lock Widgets and Remove Panel Buttons 
(Vertical) (No Separator).png 
  Let's see what others think.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, filipf, rooty, ngraham, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Nathaniel Graham]

ngraham added a comment.


  Hmm, the separator line feels like a bit much to me. How about just 
`units.largeSpacing` or `units.gridUnit` between them?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Björn Feber]

GB_2 updated this revision to Diff 55225.
GB_2 added a comment.


  Add separator and spacer between the two buttons

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20144?vs=55139&id=55225

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20144

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Nathaniel Graham]

ngraham added a comment.


  Hmm, maybe well then just with a spacer between them then?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Björn Feber]

GB_2 added a comment.


  In D20144#441087 , @ngraham wrote:
  
  > Maybe just switch the buttons' positions and add a spacer between them, 
then?
  
  
  I can try putting a spacer or seperator between the 2 buttons, but if I 
switch the positions of those 2 buttons, you can accidentally remove the panel 
when trying to close the panel edit mode.
  One thing to note though, you can always click undo removing the panel ;-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Nathaniel Graham]

ngraham added a comment.


  Maybe just switch the buttons' positions and add a spacer between them, then?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Björn Feber]

GB_2 added a comment.


  In D20144#441083 , @ngraham wrote:
  
  > +1 for moving out out from under the More Settings... button; this isn't a 
setting so that was clearly wrong. However I'm not sure I like the new 
placement of the button. Now it's right next to Lock Widgets, which is 
non-destructive. Seems like it would be easy to mis-click and accidentally blow 
away your panel--especially on touch. At a minimum I would recommend adding 
some padding between it and adjacent non-destructive buttons. And maybe Lock 
Widgets should be moved over to the right side. Thoughts?
  
  
  I'm not sure about moving `Lock Widgets` to the other side. When horizontal, 
the 4 buttons on the right/bottom will take up a lot of space, especially in 
wordy languages or when using a small screen resolution, causing them to be 
changed into icons only buttons, which we should avoid. 4 buttons on one side 
and 1 on the other side would also look quite unbalanced.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Nathaniel Graham]

ngraham added a comment.


  +1 for moving out out from under the More Settings... button; this isn't a 
setting so that was clearly wrong. However I'm not sure I like the new 
placement of the button. Now it's right next to Lock Widgets, which is 
non-destructive. Seems like it would be easy to mis-click and accidentally blow 
away your panel--especially on touch. At a minimum I would recommend adding 
some padding between it and adjacent non-destructive buttons. And maybe Lock 
Widgets should be moved over to the right side. Thoughts?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20144

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 406079
  
  Move these two buttons to the left/top of the panel edit mode toolbar.
  
  Horizontal:
  F6739522: More Obvious Location of Lock Widgets and Remove Panel Buttons 
(Horizontal).png 
  
  Verical:
  F6739523: More Obvious Location of Lock Widgets and Remove Panel Buttons 
(Vertical).png 

TEST PLAN
  Open the panel edit mode.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20144

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart