D20612: [Kickoff] Modernize settings window layout

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7bbe5fc1e1fa: [Kickoff] Modernize settings window layout 
(authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20612?vs=56561&id=56751

REVISION DETAIL
  https://phabricator.kde.org/D20612

AFFECTED FILES
  applets/kickoff/package/contents/config/config.qml
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml

To: ngraham, #plasma, #vdg, filipf, hein
Cc: hein, filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [Kickoff] Modernize settings window layout

[Eike Hein]

hein accepted this revision.
hein added a comment.


  LGTM.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

To: ngraham, #plasma, #vdg, filipf, hein
Cc: hein, filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [Kickoff] Modernize settings window layout

[Nathaniel Graham]

ngraham updated this revision to Diff 56561.
ngraham added a comment.


  largeSpacing -> smallSpacing

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20612?vs=56550&id=56561

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

AFFECTED FILES
  applets/kickoff/package/contents/config/config.qml
  applets/kickoff/package/contents/ui/ConfigButtons.qml
  applets/kickoff/package/contents/ui/ConfigGeneral.qml

To: ngraham, #plasma, #vdg, filipf
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [Kickoff] Modernize settings window layout

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> filipf wrote in ConfigButtons.qml:29
> maybe `units.smallSpacing` would be enough, what do you think?

Yeah, good call

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

To: ngraham, #plasma, #vdg, filipf
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [Kickoff] Modernize settings window layout

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ConfigButtons.qml:29
>  
> -cellHeight: units.gridUnit * 5
> +cellHeight: units.gridUnit * 6 + units.largeSpacing
>  cellWidth: units.gridUnit * 6

maybe `units.smallSpacing` would be enough, what do you think?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

To: ngraham, #plasma, #vdg, filipf
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20612: [Kickoff] Modernize settings window layout

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Nice! The last label is getting cut off for me with the default window size, 
but not sure what could be done about it.
  
  F6780515: image.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kickoff-settings-layout-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20612

To: ngraham, #plasma, #vdg, filipf
Cc: filipf, GB_2, broulik, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart