D20773: [Task Manager] Bring to current desktop with middle-click

2019-04-24 Thread Thomas Surrel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a416f16b562b: [Task Manager] Bring to current desktop 
with middle-click (authored by thsurrel).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20773?vs=56865&id=56875

REVISION DETAIL
  https://phabricator.kde.org/D20773

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/plugin/backend.h

To: thsurrel, #plasma, hein
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20773: [Task Manager] Bring to current desktop with middle-click

2019-04-24 Thread Thomas Surrel 
thsurrel updated this revision to Diff 56865.
thsurrel added a comment.


  Fixes as per Nate's comments.
  Thanks for the review!

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20773?vs=56842&id=56865

BRANCH
  arc_middleclick

REVISION DETAIL
  https://phabricator.kde.org/D20773

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/plugin/backend.h

To: thsurrel, #plasma, hein
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20773: [Task Manager] Bring to current desktop with middle-click

2019-04-23 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> ConfigBehavior.qml:116
> +i18nc("When clicking it would toggle grouping windows of a 
> specific app", "Group/Ungroup"),
> +i18n("Bring to the current desktop")
>  ]

Maybe "virtual desktop" instead of just "desktop"?

> backend.h:55
> +ToggleGrouping,
> + BringToCurrentDesktop
>  };

Indentation

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20773

To: thsurrel, #plasma, hein
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20773: [Task Manager] Bring to current desktop with middle-click

2019-04-23 Thread Thomas Surrel 
thsurrel created this revision.
thsurrel added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  This adds a new possible action when middle-click is used on a task
  in the task manager: bringing that task to the current desktop.
  
  FEATURE: 360250

TEST PLAN
  In the task manager settings > Behavior > On middle-click, select
  'Bring to the current desktop', and make sure 'Show only tasks from
  the current desktop' is deselected.
  Having several applications opened on different virtual desktops,
  middle-click on a task from another desktop and check that it is
  brought to the current one.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_middleclick

REVISION DETAIL
  https://phabricator.kde.org/D20773

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/plugin/backend.h

To: thsurrel, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart