D21492: Remove double look-ups

2019-05-30 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1abcdd51839d: Remove double look-ups (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21492?vs=58876&id=58896#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21492?vs=58876&id=58896

REVISION DETAIL
  https://phabricator.kde.org/D21492

AFFECTED FILES
  shell/shellcorona.cpp

To: apol, #plasma, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21492: Remove double look-ups

2019-05-30 Thread Kai Uwe Broulik 
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> shellcorona.cpp:1068
> +auto itDesktop = m_desktopViewforId.find(idx);
> +if (itDesktop == m_desktopViewforId.constEnd()) {
>  return;

Compare with `end()` since you're not using `constFind()`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21492

To: apol, #plasma, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21492: Remove double look-ups

2019-05-29 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

TEST PLAN
  plasmashell still works fine

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21492

AFFECTED FILES
  shell/shellcorona.cpp

To: apol, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart