D21510: Filter KNewStuff Plasma Themes by Download Tag

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e93b567ecb7f: Filter KNewStuff Plasma Themes by Download Tag (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21510?vs=61120=61196#toc REPOSITORY R119 Plasma Desktop

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir added a comment. In D21510#490851 , @ngraham wrote: > In D21510#488800 , @leinir wrote: > > > In D21510#488646 , @ngraham wrote: > > > > > Yep,

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir added a comment. In D21510#490850 , @ngraham wrote: > In D21510#490635 , @leinir wrote: > > > - Also filter on the ghns_excluded tag, otherwise they'll be shown... > > > I thought that

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham added a comment. In D21510#488800 , @leinir wrote: > In D21510#488646 , @ngraham wrote: > > > Yep, seems to work and makes sense. Let's get this in so we can start tagging things. > >

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham added a comment. In D21510#490635 , @leinir wrote: > - Also filter on the ghns_excluded tag, otherwise they'll be shown... I thought that was taken care of on the server side? REPOSITORY R119 Plasma Desktop BRANCH

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir updated this revision to Diff 61120. leinir added a comment. - Also filter on the ghns_excluded tag, otherwise they'll be shown... REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21510?vs=58937=61120 BRANCH filter-themes-by-download-tags

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir added a comment. In D21510#488646 , @ngraham wrote: > Yep, seems to work and makes sense. Let's get this in so we can start tagging things. Aaaawesomesauce :) Land on master, or 5.16, or? REPOSITORY R119 Plasma Desktop BRANCH

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, seems to work and makes sense. Let's get this in so we can start tagging things. REPOSITORY R119 Plasma Desktop BRANCH filter-themes-by-download-tags (branched from master)

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir added a comment. In D21510#472572 , @ngraham wrote: > Can you update the test plan to provide examples of themes that are correctly tagged so we can test this? > > - Plasma 5 only theme > - Plasma 4 only theme > - Theme that works

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham added a comment. Can you update the test plan to provide examples of themes that are correctly tagged so we can test this? - Plasma 5 only theme - Plasma 4 only theme - Theme that works on both Plasma 4 and 5 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir added a comment. In D21510#472514 , @ngraham wrote: > Is the content actually tagged appropriately yet? When I test this out I see no effect, i.e. old Plasma 4 themes like OLED Orange (https://store.kde.org/p/998790/) are still visible.

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham added a comment. Is the content actually tagged appropriately yet? When I test this out I see no effect, i.e. old Plasma 4 themes like OLED Orange (https://store.kde.org/p/998790/) are still visible. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir updated this revision to Diff 58937. leinir added a comment. - Add TagFilter (for top level tags), and don't explicitly reject 4 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21510?vs=58935=58937 BRANCH filter-themes-by-download-tags

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Following a lengthy discussion on the topic[1], the first step towards getting themes cleaned up and hidden when they don't work