D21869: [RFC] Change border for "separator_menu_item" line-h.png

[Nathaniel Graham]

ngraham added a comment.


  I don't know, sorry.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D21869

To: vzapod, #breeze, mthw, gepardo, jackg
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21869: [RFC] Change border for "separator_menu_item" line-h.png

[Valerii Zapod]

vzapod added a comment.


  In D21869#481220 , @ngraham wrote:
  
  > "Edit Revision, which is on the sidebar in the top-right, or under the 
Actions hamburger menu in the top-right.
  
  
  I know how to do it. But really have you read 
https://wiki.gnome.org/Attic/GnomeArt/Tutorials/GtkEngines/PixmapEngine
  down to:
  "How to theme a GtkHSeparator with an image:"
  
  It uses all 0s why?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D21869

To: vzapod, #breeze, mthw, gepardo, jackg
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21869: [RFC] Change border for "separator_menu_item" line-h.png

[Nathaniel Graham]

ngraham added reviewers: Breeze, mthw, gepardo, jackg.
ngraham added a comment.


  Vlad is saying that this patch's description section needs a short 
explanation describing why the change is necessary. You can do this by clicking 
"Edit Revision, which is on the sidebar in the top-right, or under the Actions 
hamburger menu in the top-right.
  
  Adding some more reviewers.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D21869

To: vzapod, #breeze, mthw, gepardo, jackg
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21869: [RFC] Change border for "separator_menu_item" line-h.png

[Valerii Zapod]

vzapod added a comment.


  Can you add it yourself? Or propose a name for me. Besides that you should 
understand that I know nothing about themes and pixmap engine. Can you tell me 
if all 0s are good thing? Should not it me something connected with line-h.png 
size? Can you say that 1, 1, 1, 1 is no-no?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D21869

To: vzapod
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21869: [RFC] Change border for "separator_menu_item" line-h.png

[Vlad Zagorodniy]

zzag added a comment.


  Can you add some meaningful commit message?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D21869

To: vzapod
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21869: [RFC] Change border for "separator_menu_item" line-h.png

[Valerii Zapod]

vzapod created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vzapod requested review of this revision.

REVISION SUMMARY
  BUG: 404045

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D21869

AFFECTED FILES
  src/gtk2/widgets/menu

To: vzapod
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart