D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f3d914c0fafc: Port FolderView to ContainmentLayoutManager 
plugin (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22035?vs=61988&id=62269#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22035?vs=61988&id=62269

REVISION DETAIL
  https://phabricator.kde.org/D22035

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/ResizeHandle.qml
  containments/desktop/package/contents/ui/code/LayoutManager.js
  containments/desktop/package/contents/ui/main.qml
  desktoppackage/contents/updates/move_desktop_layout_config.js

To: mart, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ConfigOverlay.qml:171
> why do we do it explicitly here, but backed by a timer for movement?

This is after being rotated, when changing rotation of an item the same doesn't 
get invoked automatically

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/newlayout

REVISION DETAIL
  https://phabricator.kde.org/D22035

To: mart, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

mart updated this revision to Diff 61988.
mart marked an inline comment as done.
mart added a comment.


  - remove leftovers

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22035?vs=61974&id=61988

BRANCH
  mart/newlayout

REVISION DETAIL
  https://phabricator.kde.org/D22035

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/ResizeHandle.qml
  containments/desktop/package/contents/ui/code/LayoutManager.js
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/ConfigOverlay.qml
  desktoppackage/contents/updates/move_desktop_layout_config.js

To: mart, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ConfigOverlay.qml:171
> +//print("saving...");
> +appletsLayout.save();
> +}

why do we do it explicitly here, but backed by a timer for movement?

> main.qml:346
> +acceptsAppletCallback: function(applet, x, y) {
> +print("Applet: "+applet+" "+x+" "+y)
> +return true;

leftover debug

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/newlayout

REVISION DETAIL
  https://phabricator.kde.org/D22035

To: mart, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

mart updated this revision to Diff 61974.
mart added a comment.


  - use the locked editmodecondition

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22035?vs=61577&id=61974

BRANCH
  mart/newlayout

REVISION DETAIL
  https://phabricator.kde.org/D22035

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/ResizeHandle.qml
  containments/desktop/package/contents/ui/code/LayoutManager.js
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/ConfigOverlay.qml
  desktoppackage/contents/updates/move_desktop_layout_config.js

To: mart, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

mart updated this revision to Diff 61577.
mart added a comment.


  - adapt to api change
  - add migration script

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22035?vs=60493&id=61577

BRANCH
  mart/newlayout

REVISION DETAIL
  https://phabricator.kde.org/D22035

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/ResizeHandle.qml
  containments/desktop/package/contents/ui/code/LayoutManager.js
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/ConfigOverlay.qml
  desktoppackage/contents/updates/move_desktop_layout_config.js

To: mart, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

mart updated this revision to Diff 60493.
mart added a comment.


  - remove dead code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22035?vs=60461&id=60493

BRANCH
  mart/newlayout

REVISION DETAIL
  https://phabricator.kde.org/D22035

AFFECTED FILES
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/desktop/package/contents/ui/ResizeHandle.qml
  containments/desktop/package/contents/ui/code/LayoutManager.js
  containments/desktop/package/contents/ui/main.qml
  containments/panel/contents/ui/ConfigOverlay.qml

To: mart
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Nathaniel Graham]

ngraham added a comment.


  Works perfectly with my testing on using both a pointing device and 
touchscreen. The touchscreen use case in particular is hugely improved.
  
  I'm not an expert on this code, but it looks pretty sane to me on 
read-through.

INLINE COMMENTS

> main.qml:322
> +/*
>  MouseArea { // unfocus any plasmoid when clicking empty desktop area
>  anchors.fill: parent

The feature seems to work without this commented code; can we remove it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22035

To: mart
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Nathaniel Graham]

ngraham added a comment.


  +1 visually!
  
  I wonder if it might make sense to make the icons on the handle bigger even 
in desktop mode. They're awfully small, and bigger click targets can help 
desktop users, too.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22035

To: mart
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22035: Port FolderView to ContainmentLayoutManager plugin

[Marco Martin]

mart added a comment.


  Before:
  F6927347: Screenshot_20190623_140805.png 

  After:
  F6927342: Screenshot_20190623_140647.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22035

To: mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart