D22065: Introduce PluginManager
This revision was automatically updated to reflect the committed changes. Closed by commit R856:cc4436cf491c: Introduce PluginManager (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22065?vs=60997&id=61211 REVISION DETAIL https://phabricator.kde.org/D22065 AFFECTED FILES host/CMakeLists.txt host/abstractbrowserplugin.cpp host/abstractbrowserplugin.h host/main.cpp host/pluginmanager.cpp host/pluginmanager.h host/settings.cpp To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22065: Introduce PluginManager
broulik updated this revision to Diff 60997. broulik added a comment. - Also remove `pluginProtocolVersion`, can just call `AbstractBrowserPlugin::protocolVersion()` REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22065?vs=60996&id=60997 REVISION DETAIL https://phabricator.kde.org/D22065 AFFECTED FILES host/CMakeLists.txt host/abstractbrowserplugin.cpp host/abstractbrowserplugin.h host/main.cpp host/pluginmanager.cpp host/pluginmanager.h host/settings.cpp To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22065: Introduce PluginManager
broulik updated this revision to Diff 60996. broulik added a comment. - Operate on `AbstractBrowserPlugin *` exclusively - Cleanup REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22065?vs=60554&id=60996 REVISION DETAIL https://phabricator.kde.org/D22065 AFFECTED FILES host/CMakeLists.txt host/abstractbrowserplugin.cpp host/abstractbrowserplugin.h host/main.cpp host/pluginmanager.cpp host/pluginmanager.h host/settings.cpp To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D22065: Introduce PluginManager
fvogt added inline comments.
INLINE COMMENTS
> pluginmanager.cpp:39
> +
> +void PluginManager::init()
> +{
Never called
> pluginmanager.cpp:69
> +
> +bool PluginManager::setPluginLoaded(const QString &subsystem, bool loaded)
> +{
I'd change this to accept the an AbstractBrowserPlugin pointer instead of the
subsystem and do the lookup in `bool PluginManager::loadPlugin(const QString
&subsystem)` instead.
Or just expose a `PluginManager::pluginForSubsystem(subsystem)` method.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D22065
To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, mart
D22065: Introduce PluginManager
broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This adds a dedicated class for loading/unloading and sending data to a plugin rather than doing it all in `main()` It could in the future then handle things like sending a reply to an incoming dataset by storing a reference/identifier to the request etc. TEST PLAN - Loading and unloading plugins still works - Plugins still work Behavior on browser side is unchanged and/or protocol structure REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D22065 AFFECTED FILES host/CMakeLists.txt host/abstractbrowserplugin.cpp host/abstractbrowserplugin.h host/main.cpp host/pluginmanager.cpp host/pluginmanager.h host/settings.cpp To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
