D22128: [Kickoff] Redo tab bar separator's geometry

This revision was automatically updated to reflect the committed changes. Closed by commit R119:76045bf20e07: [Kickoff] Redo tab bar separators geometry (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22128?vs=60750=61179 REVISION

D22128: [Kickoff] Redo tab bar separator's geometry

filipf added a comment. Can anyone from #plasma have a quick look if this is okay? I went with the approach of not initially defining geometry, and define it only as a part of the anchor changes? REPOSITORY R119 Plasma Desktop BRANCH

D22128: [Kickoff] Redo tab bar separator's geometry

ngraham accepted this revision. ngraham added a comment. In D22128#487965 , @ndavis wrote: > Sorry, my bad once again. I hadn't actually applied D22108 . It works for me now. The tab highlight width problem

D22128: [Kickoff] Redo tab bar separator's geometry

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Sorry, my bad once again. I hadn't actually applied D22108 . It works for me now. The tab highlight width problem must be somewhere else since this

D22128: [Kickoff] Redo tab bar separator's geometry

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. whoops, didn't mean to accept REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22128 To: filipf, #plasma, #vdg, ndavis Cc: ngraham, ndavis,

D22128: [Kickoff] Redo tab bar separator's geometry

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D22128#487943 , @ngraham wrote: > Even after also applying D22108 it's better but still not quite

D22128: [Kickoff] Redo tab bar separator's geometry

filipf added a comment. In D22128#487943 , @ngraham wrote: > Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen): F6941090:

D22128: [Kickoff] Redo tab bar separator's geometry

ngraham added a comment. Even after also applying D22108 it's better but still not quite touching the line for me (1x scale, 1080p screen): F6941090: Screenshot_20190628_145136.png REPOSITORY R119 Plasma Desktop

D22128: [Kickoff] Redo tab bar separator's geometry

filipf added a comment. Don't know, I removed both of the patches and the issue's still there. Yeah this was 2x scaling and the indicator should be 6px. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22128 To: filipf, #plasma, #vdg Cc: ndavis, plasma-devel,

D22128: [Kickoff] Redo tab bar separator's geometry

ndavis added a comment. Since these seem to be scaled 2x, the thicker (6px@2x) highlight is more desirable. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22128 To: filipf, #plasma, #vdg Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D22128: [Kickoff] Redo tab bar separator's geometry

ndavis added a comment. Why is the tab highlight thicker in these F6939066: Screenshot_20190627_234222.png F6939070: Screenshot_20190628_000624.png And thinner in these? F6939067:

D22128: [Kickoff] Redo tab bar separator's geometry

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch makes Kickoff tab indicators glide(patch _) on the tab bar separator in all 4 orientations. REPOSITORY R119 Plasma