D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62859. cblack added a comment. Dump the rest of the colors. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62847=62859 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread David Redondo
davidre added a comment. Sorry my bad, I misread the diff. I thought you added a new flag (as proposed above) and looked at `exportGtkTheme` but that flag is an existing one. And to my shame it doesn't even have a green background. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Carson Black
cblack added a comment. In D22844#504691 , @davidre wrote: > It seems the header with the new flag is missing from the diff. I put it alongside the content in the existing `exportColors` flag because there's no reason to make a flag for

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread David Redondo
davidre added a comment. It seems the header with the new flag is missing from the diff. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22844 To: cblack, #plasma Cc: davidre, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Carson Black
cblack updated this revision to Diff 62847. cblack added a comment. Incorporate feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22844?vs=62819=62847 BRANCH kcm-colors-gtk (branched from master) REVISION DETAIL

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-31 Thread Kai Uwe Broulik
broulik added a comment. Interesting approach! However, this doesn't seem to apply anything on first login? Maybe you want to extend the "rdb" thing instead: `runRdb(KRdbExportQtColors | KRdbExportGtkTheme | (m_applyToAlien ? KRdbExportColors : 0));` and add a `KRdbExportGtkCssColors`

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

2019-07-30 Thread Carson Black
cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This exports the active colorscheme to ~/.config/gtk-3.0/colors.css and sets up