D23463: Fix PrivateActionToolButton with menu not clearing checked state properly
This revision was automatically updated to reflect the committed changes. Closed by commit R169:7fe5a47ec705: Fix PrivateActionToolButton with menu not clearing checked state properly (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23463?vs=64664=64748 REVISION DETAIL https://phabricator.kde.org/D23463 AFFECTED FILES src/controls/private/PrivateActionToolButton.qml To: ahiemstra, #kirigami, mart, ngraham Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein
D23463: Fix PrivateActionToolButton with menu not clearing checked state properly
ahiemstra updated this revision to Diff 64664. ahiemstra added a comment. - Remove usage of no longer existing property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23463?vs=64663=64664 BRANCH fix_actiontoolbutton REVISION DETAIL https://phabricator.kde.org/D23463 AFFECTED FILES src/controls/private/PrivateActionToolButton.qml To: ahiemstra, #kirigami Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein
D23463: Fix PrivateActionToolButton with menu not clearing checked state properly
ahiemstra updated this revision to Diff 64663. ahiemstra edited the test plan for this revision. ahiemstra added a comment. - Fix null object error REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23463?vs=64662=64663 BRANCH fix_actiontoolbutton REVISION DETAIL https://phabricator.kde.org/D23463 AFFECTED FILES src/controls/private/PrivateActionToolButton.qml To: ahiemstra, #kirigami Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein
D23463: Fix PrivateActionToolButton with menu not clearing checked state properly
ahiemstra created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY When closing the menu of a PrivateActionToolButton with a click on the button, the checked state of the button would not properly clear. So instead use the button's toggled signal to handle menu open/close. Combined with a close policy where the parent is explicitly excluded we can properly clear the checked state. REPOSITORY R169 Kirigami BRANCH fix_actiontoolbutton REVISION DETAIL https://phabricator.kde.org/D23463 AFFECTED FILES src/controls/private/PrivateActionToolButton.qml To: ahiemstra Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein
