D23840: Enable HiDPI rendering for systemmonitor

2019-09-10 Thread Yunhe Guo
guoyunhe added a comment. Fixed in https://phabricator.kde.org/D23846 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23840 To: guoyunhe, #plasma, ngraham Cc: kossebau, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23840: Enable HiDPI rendering for systemmonitor

2019-09-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. And attributes in general are better set before the application instance is created. Some attributes even need that, so defaulting to it is better, REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23840 To: guoyunhe, #plasma,

D23840: Enable HiDPI rendering for systemmonitor

2019-09-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. Does this compile? What compiler are you using? At least it does not on CI: https://build.kde.org/view/Failing/job/Plasma/job/plasma-workspace/ When calling a static method of a class using the "::", one rather needs to use the classname, not the name of an

D23840: Enable HiDPI rendering for systemmonitor

2019-09-10 Thread Kai Uwe Broulik
broulik added a comment. Can you check whether window icons are still correct? See D14490 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23840 To: guoyunhe, #plasma, ngraham Cc: broulik, plasma-devel, LeGast00n,

D23840: Enable HiDPI rendering for systemmonitor

2019-09-10 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f62e2f2a0901: Enable HiDPI rendering for systemmonitor (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23840: Enable HiDPI rendering for systemmonitor

2019-09-10 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Make toolbar and menu icons sharp REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL