D24265: support global edit mode

GB_2 added a comment. In D24265#551189 , @mart wrote: > - don't dismiss applet edit mode when overing the handle Also happens with the resize handles :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24265: support global edit mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ae55560053ef: support global edit mode (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24265?vs=68414=68426#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24265: support global edit mode

GB_2 added inline comments. INLINE COMMENTS > ToolBoxButton.qml:230 > +PlasmaComponents3.ToolTip { > +text: i18n("Close Edit Mode") > +} Please change to "Finish Customizing Layout" to match the menu entry. REPOSITORY R119 Plasma Desktop

D24265: support global edit mode

mart updated this revision to Diff 68414. mart added a comment. - don't dismiss applet edit mode when overing the handle REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=68235=68414 BRANCH mart/editMode REVISION DETAIL

D24265: support global edit mode

GB_2 added a comment. In D24265#549640 , @mart wrote: > i would prefer not to, but can be tried with eventually in the future Ok, we can do that in another patch. This is fine once you address my inline comment "Not done." and fix this:

D24265: support global edit mode

mart added a comment. In D24265#549691 , @davidedmundson wrote: > Can you explain the intended difference between top and topcenter? when the toolbox is at topcenter, it snaps at center screen ,and if the resolution changes it will be

D24265: support global edit mode

mart updated this revision to Diff 68235. mart added a comment. - remove dead code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67899=68235 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 AFFECTED FILES

D24265: support global edit mode

davidedmundson added a comment. Can you explain the intended difference between top and topcenter? INLINE COMMENTS > ToolBoxButton.qml:87 > id: stateTimer > -interval: 100 > +interval: 0//toolBoxButton.state.indexOf("center") != -1 ? 0 : 100 > onTriggered:

D24265: support global edit mode

GB_2 added a comment. Why not? Currently you have to open the context menu for the panel or desktop, so it's inconsistent and confusing if you want to move a widget and the don't get the option to (without click+hold). REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION

D24265: support global edit mode

mart added a comment. In D24265#549634 , @GB_2 wrote: > I'd also add the "Customize Layout..." menu item to the widget context menu, that way you can discover it much more easily. i would prefer not REPOSITORY R119 Plasma Desktop

D24265: support global edit mode

GB_2 added a comment. I'd also add the "Customize Layout..." button to the widget menu, that way you can discover it much more easily. REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2,

D24265: support global edit mode

mart added a comment. In D24265#549583 , @GB_2 wrote: > An "Add Panel..." button in the toolbox would be very useful too :-) maybe.. tough it must have a submenus that loads the available installed panel layouts... may get messy

D24265: support global edit mode

GB_2 added a comment. An "Add Panel..." button in the toolbox would be very useful too :-) REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24265: support global edit mode

GB_2 added a comment. Only one last issue: the widget resizing handles disappear when you are on a blank area of the widget handle (the bar to the left/right). INLINE COMMENTS > GB_2 wrote in ToolBoxButton.qml:292 > This should probably be changed to "Finish Customizing Layout" to match the

D24265: support global edit mode

mart added a comment. In D24265#545990 , @GB_2 wrote: > This works very well now except for the vertical desktop toolbox. I don't think being able to have a vertical toolbox is practical, you can't really read the button labels and it's also

D24265: support global edit mode

mart updated this revision to Diff 67899. mart added a comment. - get rid of the vertical mode REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67898=67899 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265

D24265: support global edit mode

mart updated this revision to Diff 67898. mart added a comment. - don't auto close edit mode REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67719=67898 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 AFFECTED

D24265: support global edit mode

mart added a comment. In D24265#546025 , @GB_2 wrote: > BTW, it would also be nice to have click and hold on the panel to open the panel controller toolbox :-) maybe. Ii feel it kinda overkill REPOSITORY R119 Plasma Desktop BRANCH

D24265: support global edit mode

GB_2 added a comment. BTW, it would also be nice to have click and hold on the panel to open the panel controller toolbox :-) REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2,

D24265: support global edit mode

GB_2 added inline comments. INLINE COMMENTS > ToolBoxButton.qml:292 > +PlasmaComponents3.ToolTip { > +text: i18n("Close Edit Mode") > +} This should probably be changed to "Finish Customizing Layout" to match the current menu entry.

D24265: support global edit mode

GB_2 added a comment. This works very well now except for the vertical desktop toolbox. I don't think being able to have a vertical toolbar is practical, you can't really read the button labels and it's also glitching around when switching between horizontal and vertical mode. I think just

D24265: support global edit mode

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM now! REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel,

D24265: support global edit mode

mart added a comment. proper look now REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D24265: support global edit mode

mart updated this revision to Diff 67719. mart added a comment. - proper plasmoid background REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67189=67719 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 AFFECTED

D24265: support global edit mode

mart added a comment. hold on, there is some clipping going on actually REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot,

D24265: support global edit mode

mart added a comment. In D24265#545400 , @GB_2 wrote: > It would be nice if the desktop toolbox had a shadow and had the standard background. it has, as it has the standard background of plasmoids (is not a window, so it can't

D24265: support global edit mode

ngraham added a comment. In D24265#545400 , @GB_2 wrote: > It would be nice if the desktop toolbox had a shadow and had the standard background. Yeah. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24265: support global edit mode

GB_2 added a comment. It would be nice if the desktop toolbox had a shadow and had the standard background. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24265: support global edit mode

mart added a comment. does that on current version of D24264 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24265: support global edit mode

ngraham added a comment. In D24265#545274 , @mart wrote: > tough i think then it should be there also for pure touch events as well (as opposed to clicks) > > As any change i'll do in plasma is primarly be in the direction of making touch a

D24265: support global edit mode

mart added a comment. In D24265#544658 , @ngraham wrote: > In D24265#544549 , @mart wrote: > > > I actually like that a lot, to me is really the click anywhere to dismiss pattern all over the place

D24265: support global edit mode

ngraham added a comment. In D24265#544549 , @mart wrote: > I actually like that a lot, to me is really the click anywhere to dismiss pattern all over the place in modal dialogs, websites and what not. > If I have to remove it, i would at

D24265: support global edit mode

mart added a comment. In D24265#544299 , @ngraham wrote: > Hmm, I have some UX concerns here after trying it out: > > If I invoke Present Windows to see the desktop so that I can right-click on it to enter edit mode, when I exit the mode,

D24265: support global edit mode

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, I have some UX concerns here after trying it out: If I invoke Present Windows to see the desktop so that I can right-click on it to enter edit mode, when I exit the

D24265: support global edit mode

mart added a comment. latest version of D24264 does show the desktop when in edit mode (and as sideeffect edit mode doesn't close when the widget explorer is closed) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265

D24265: support global edit mode

mart added a comment. In D24265#543873 , @ngraham wrote: > I would tend to agree. If we feel that it's too difficult to exit this mode, maybe we should make it more obvious, like changing the X button in the toolbox to a toolbutton with the

D24265: support global edit mode

GB_2 added a comment. In D24265#544016 , @mart wrote: > this happens because some other window gets focus (that behavior in somewhere deep in kwin and i think makes sense). > Would you keep edit mode active when the focus goes to another app?

D24265: support global edit mode

mart added a comment. this happens because some other window gets focus (that behavior in somewhere deep in kwin and i think makes sense). Would you keep edit mode active when the focus goes to another app? I'm very hesitant about that and don't really like the concept... REPOSITORY

D24265: support global edit mode

ngraham added a comment. I would tend to agree. If we feel that it's too difficult to exit this mode, maybe we should make it more obvious, like changing the X button in the toolbox to a toolbutton with the "finish editing" text. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24265: support global edit mode

GB_2 added a comment. In D24265#543873 , @ngraham wrote: > I would tend to agree. If we feel that it's too difficult to exit this mode, maybe we should make it more obvious, like changing the X button in the toolbox to a toolbutton with the

D24265: support global edit mode

GB_2 added a comment. In D24265#543173 , @mart wrote: > hmm, not sure it's a bad thing, it all makes this mode to automatically exit.. which makes it almost a "quasimode", countering a bit the evils of being a modal ui When you are done

D24265: support global edit mode

mart added a comment. In D24265#541411 , @GB_2 wrote: > - when you open the desktop context menu it enters the edit mode automatically (probably because it thinks you still click) with latest version of D24264

D24265: support global edit mode

mart added a comment. In D24265#541411 , @GB_2 wrote: > A few bugs I found: > > - when you open the desktop context menu it enters the edit mode automatically (probably because it thinks you still click) gah, yet another bug of the

D24265: support global edit mode

GB_2 added a comment. A few bugs I found: - when you open the desktop context menu it enters the edit mode automatically (probably because it thinks you still click) - after closing the panel controller or "Add Widgets..." sidebar it closes the edit mode too REPOSITORY R119 Plasma

D24265: support global edit mode

mart updated this revision to Diff 67189. mart added a comment. - don't raise the icons over the toolbox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67186=67189 BRANCH mart/editMode REVISION DETAIL

D24265: support global edit mode

mart updated this revision to Diff 67186. mart added a comment. - state machine for right order of opacity and visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67069=67186 BRANCH mart/editMode REVISION DETAIL

D24265: support global edit mode

mart updated this revision to Diff 67069. mart added a comment. - state machine for right order of opacity and visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=66955=67069 BRANCH mart/editMode REVISION DETAIL

D24265: support global edit mode

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > mart wrote in ToolBoxButton.qml:286 > latest revision should fix that actually, revision of D24263 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24265: support global edit mode

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > ngraham wrote in ToolBoxButton.qml:286 > Locking the widgets while in edit mode doesn't update the menu item, so it's > possible to end up in this state: > > F7448695: Screenshot_20190927_111420.png >

D24265: support global edit mode

ngraham added inline comments. INLINE COMMENTS > ToolBoxButton.qml:286 > +icon.height: units.iconSizes.smallMedium > +onClicked: qAction.trigger() > +} Locking the widgets while in edit mode doesn't update the menu item, so it's possible to end up in

D24265: support global edit mode

mart added a comment. yes, it's completely ortogonal to that one REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D24265: support global edit mode

GB_2 added a comment. Nice! I guess D23951 is still relevant? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D24265: support global edit mode

mart added a comment. still has the problem of long press not working with the folderview layout (stolen events) will look into that REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24265: support global edit mode

mart added a comment. F7447783: vokoscreen-2019-09-27_17-03-51.mp4 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24265: support global edit mode

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY desktop and panel toolboxes are only visible in "edit mode" edit mode can be triggered by - long