D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-05 Thread Yunhe Guo
guoyunhe added a comment. Reverted https://cgit.kde.org/plasma-workspace.git/commit/?id=0e14429e7355e07913ea21ab03abde6dc1ae8a1f REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24409 To: guoyunhe, #plasma_workspaces, ngraham Cc: ltoscano, aacid, ngraham,

D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-05 Thread Luigi Toscano
ltoscano added a comment. I think you need to bump the dependency on the newer KService, which means the dependency on the newest (right now unreleased) Frameworks. If I am correct, can you please revert this and push it again when the Plasma team decides to bump the dependency?

D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-05 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a4d6c8c02a5e: Remove kf5-toys.directory because it will not be used by other packages (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-05 Thread Yunhe Guo
guoyunhe added a comment. D24384 has been accepted and seems no one strongly against it... So I landed it. Can you give this patch an approval? @davidedmundson REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24409 To:

D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-04 Thread Yunhe Guo
guoyunhe added subscribers: ngraham, aacid. guoyunhe added a comment. In D24409#541894 , @davidedmundson wrote: > Ship it (if and only if the other patch is also accepted) The other patch is accepted by @ngraham . But @aacid has

D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-04 Thread David Edmundson
davidedmundson added a comment. Ship it (if and only if the other patch is also accepted) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24409 To: guoyunhe, #plasma_workspaces Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24409: Remove kf5-toys.directory because it will not be used by other packages

2019-10-04 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY See also D24384 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL