D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

[Nathaniel Graham]

ngraham added a comment.


  In D24842#551772 , @filipf wrote:
  
  > Makes sense. It's unrelated to this patch but what's up with the double 
message ("No space on device left" and "not enough free disk space") here?
  
  
  Yeah I need to fix that too.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24842

To: ngraham, #vdg, #discover_software_store, apol, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:62d595f24db6: Use the text OK instead of 
Proceed in updates dialog when things go wrong (authored by 
ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24842?vs=68477=68492

REVISION DETAIL
  https://phabricator.kde.org/D24842

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #vdg, #discover_software_store, apol, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Makes sense. It's unrelated to this patch but what's up with the double 
message ("No space on device left" and "not enough free disk space") here?

REPOSITORY
  R134 Discover Software Store

BRANCH
  proceed-to-ok (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24842

To: ngraham, #vdg, #discover_software_store, apol, filipf
Cc: filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24842: Use the text "OK" instead of "Proceed" in updates dialog when things go wrong

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Otherwise the button says "Proceed" when the dialog is showing you an error 
condition
  in which you cannot proceed:
  F7642500: not enough space.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  proceed-to-ok (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24842

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart