D24986: [wallpapers/image] Randomise new batches of images in the slideshow
ngraham added a comment. Landed this on the 5.17 branch just now to make sure it gets in for Plasma 5.17.2. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24986 To: davidedmundson, #plasma, ngraham, davidre Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24986: [wallpapers/image] Randomise new batches of images in the slideshow
This revision was automatically updated to reflect the committed changes. Closed by commit R120:9dca7d6cd44c: [wallpapers/image] Randomise new batches of images in the slideshow (authored by davidedmundson, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24986?vs=68840=68999 REVISION DETAIL https://phabricator.kde.org/D24986 AFFECTED FILES wallpapers/image/slidefiltermodel.cpp To: davidedmundson, #plasma, ngraham, davidre Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24986: [wallpapers/image] Randomise new batches of images in the slideshow
davidre added a comment. To clarify my comment refers to > The logic is fine but if we start with 0 wallpapers and then add 20 newones we don't shuffle anything. For the other cases shuffling the added images is probably the right thing REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24986 To: davidedmundson, #plasma, ngraham Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24986: [wallpapers/image] Randomise new batches of images in the slideshow
davidre added a comment. Are you sure? Shouldn't we be hitting this case: https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/image.cpp#n773 ? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24986 To: davidedmundson, #plasma, ngraham Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24986: [wallpapers/image] Randomise new batches of images in the slideshow
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY There was a concious decision that when we add a new wallpaper we should append to the existing random order collection, rather than shuffle existing ones. The logic is fine but if we start with 0 wallpapers and then add 20 new ones we don't shuffle anything. This patch changes it so when a new batch of N wallpapers is added, those N are shuffled when appending to the existing sort order. BUG: 413463 FIXED-IN: 5.17.2 TEST PLAN qDebug + ran a few times REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24986 AFFECTED FILES wallpapers/image/slidefiltermodel.cpp To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
