D25222: [Lock Screen] Fix album art binding loop

filipf abandoned this revision. filipf added a comment. continued in D25252 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25222 To: filipf, davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25222: [Lock Screen] Fix album art binding loop

davidedmundson added inline comments. INLINE COMMENTS > MediaControls.qml:103 > source: mpris2Source.albumArt > -sourceSize: Qt.size(width, height) > +sourceSize: Qt.size(paintedWidth, paintedHeight) > visible: status === Image.Loading || status =

D25222: [Lock Screen] Fix album art binding loop

filipf added a comment. Yeah you guys are right. I tested this further and still got some binding loop errors with paintedWidth/Height. If you have a solution feel free to commandeer the revision to speed things up, this seems like a very important bugfix. REPOSITORY R120 Plasma Works

D25222: [Lock Screen] Fix album art binding loop

davidedmundson added inline comments. INLINE COMMENTS > MediaControls.qml:98 > id: albumArt > Layout.preferredWidth: height > Layout.fillHeight: true Aha, because of this! A change in aspect ratio affects the width, which reloads the image, which changes t

D25222: [Lock Screen] Fix album art binding loop

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Can you talk me through how this creates a loop? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25222 To: filipf, davidedmundso

D25222: [Lock Screen] Fix album art binding loop

broulik added a comment. Painted size depends on the aspect ratio of the loaded image. I think it should just be hard-coded to some icon size or grid unit rather than depend on the highly dynamic font rendering (which governs its size effectively as it's the layout's size) REPOSITORY R120

D25222: [Lock Screen] Fix album art binding loop

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Album art was patched in 5.16.5 to use PreserveAspectFit, but the code for sourceSize was still applying the width and the height of