D25709: Make it compile against qt5.14 without deprecated method
This revision was automatically updated to reflect the committed changes. Closed by commit R858:8eca435225b6: Make it compile against qt5.14 without deprecated method (authored by mlaurent). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25709?vs=70876&id=70891 REVISION DETAIL https://phabricator.kde.org/D25709 AFFECTED FILES plugin/kquickstyleitem.cpp plugin/qqc2desktopstyleplugin.cpp To: mlaurent, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25709: Make it compile against qt5.14 without deprecated method
mlaurent updated this revision to Diff 70876. mlaurent added a comment. Forgot to commit it REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25709?vs=70875&id=70876 BRANCH fix_compile_qt5.14 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25709 AFFECTED FILES plugin/kquickstyleitem.cpp plugin/qqc2desktopstyleplugin.cpp To: mlaurent, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25709: Make it compile against qt5.14 without deprecated method
mlaurent updated this revision to Diff 70875. mlaurent added a comment. Fix comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25709?vs=70808&id=70875 BRANCH fix_compile_qt5.14 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25709 AFFECTED FILES plugin/kquickstyleitem.cpp plugin/qqc2desktopstyleplugin.cpp To: mlaurent, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25709: Make it compile against qt5.14 without deprecated method
mlaurent added a comment. yep it seems more logical REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D25709 To: mlaurent, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25709: Make it compile against qt5.14 without deprecated method
apol added inline comments.
INLINE COMMENTS
> kquickstyleitem.cpp:112
> +#else
> +qmlRegisterAnonymousType("org.kde.qqc2-desktop-style", 1);
> +#endif
Maybe use `org.kde.qqc2desktopstyle.private` which we are already using?
Also shouldn't we be registering the types and the plugin class rather than on
every instance of the type?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D25709
To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D25709: Make it compile against qt5.14 without deprecated method
mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Compile against 5.14 without deprecated method REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH fix_compile_qt5.14 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25709 AFFECTED FILES plugin/kquickstyleitem.cpp To: mlaurent Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
