D26658: WIP: fix(kwayland): stall tablet config change
romangg updated this revision to Diff 73630. romangg added a comment. - Init tablet before starting KWayland timer Further analysis showed that the issue is that for some reason the d-bus call to tablet mode properties is blocking for over one second. That in return leads to the single-shot timer failing. While we should not fail in this case that badly and in KWin it should be further investigated why the d-bus call is blocking for so long (it only blocks on startup, later on not anymore), for now move the tablet init before the timer is started. Then we should not fail any more on receiving the Wayland interfaces. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26658?vs=73514=73630 BRANCH tablet-fix REVISION DETAIL https://phabricator.kde.org/D26658 AFFECTED FILES backends/kwayland/waylandconfig.cpp To: romangg, #plasma, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26658: WIP: fix(kwayland): stall tablet config change
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY It seems only checking on no outputs initializing and signals being unblocked is not enough when cancelling a config change on tablet mode information change. There can be a race between the interface being announced and tablet mode information being changed before any output device received. In this case a config change is applied with no output management yet being available. Looking at the code though this seems to only be possible if the interfaces announced event is received before the output maangement interface announced event. This is not what should happen. TEST PLAN Starts without seg fault on output management object in applyConfig. REPOSITORY R110 KScreen Library BRANCH tablet-fix REVISION DETAIL https://phabricator.kde.org/D26658 AFFECTED FILES backends/kwayland/waylandconfig.cpp backends/kwayland/waylandconfig.h To: romangg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
