sitter marked an inline comment as done.
sitter added inline comments.
INLINE COMMENTS
> jjazeix wrote in nic.cpp:137
> buf is not defined in this conditional and causes a build fail on freebsd:
>
jjazeix added inline comments.
INLINE COMMENTS
> nic.cpp:137
> +#ifdef HAVE_STRUCT_SOCKADDR_SA_LEN
> +return getnameinfo(addr, ifa->ifa_addr->sa_len, buf, 127, 0, 0,
> NI_NUMERICHOST);
> +#else
buf is not defined in this conditional and causes a build fail on freebsd:
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:4582053b7cac: do not disable getifaddrs use because of
sa_len availablility (authored by sitter).
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
sitter updated this revision to Diff 73777.
sitter added a comment.
committing the latest working tree helps a lot -.-
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26729?vs=73776=73777
BRANCH
ipv6
REVISION DETAIL
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
this fixes ipv6 support in nic listing. well, kinda.
the getifaddrs branch is the only one supporting ipv6 properly
so it
