D26891: Upgrade theme to Breeze GTK on startup

This revision was automatically updated to reflect the committed changes. Closed by commit R99:d892dc2b44ae: Upgrade theme to Breeze GTK on startup (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26891?vs=74881=75002

D26891: Upgrade theme to Breeze GTK on startup

fvogt accepted this revision. fvogt added a comment. In D26891#605464 , @ngraham wrote: > LGTM now. @meven and @fvogt, you good with this too? Not sure what the rename was about, but yes, still LGTM. REPOSITORY R99 KDE Gtk

D26891: Upgrade theme to Breeze GTK on startup

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM now. @meven and @fvogt, you good with this too? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH apply-theme-on-startup (branched from master) REVISION DETAIL

D26891: Upgrade theme to Breeze GTK on startup

gikari updated this revision to Diff 74881. gikari added a comment. Rename files to provide ground for more kconf scripts in the future REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26891?vs=74815=74881 BRANCH apply-theme-on-startup

D26891: Upgrade theme to Breeze GTK on startup

gikari added a comment. The differences between `gtkrc` and `gtkrc-2.0` at least is that the first one was used for `GTK1` and the second for `GTK2`. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To: gikari, fvogt Cc: ngraham, meven,

D26891: Upgrade theme to Breeze GTK on startup

fvogt added a comment. The only remaining question from my side is why we have four different gtk configuration files and whether that causes issues. Besides that, only @meven's comment needs a resolution. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D26891: Upgrade theme to Breeze GTK on startup

ngraham added a comment. @fvogt, are you good with this now? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To: gikari, fvogt Cc: ngraham, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26891: Upgrade theme to Breeze GTK on startup

gikari updated this revision to Diff 74815. gikari edited the test plan for this revision. gikari added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26891?vs=74386=74815 BRANCH apply-theme-on-startup

D26891: Upgrade theme to Breeze GTK on startup

gikari added a comment. In D26891#601329 , @fvogt wrote: > Tested, confirmed to work. > > I wonder what's up with the gtkrc files everywhere: > > ~/.config/gtkrc-2.0 > ~/.config/gtkrc > ~/.gtkrc-2.0 > ./.config/gtk-3.0 >

D26891: Upgrade theme to Breeze GTK on startup

fvogt added a comment. Tested, confirmed to work. I wonder what's up with the gtkrc files everywhere: ~/.config/gtkrc-2.0 ~/.config/gtkrc ~/.gtkrc-2.0 ./.config/gtk-3.0 It seems like the first two are created by krdb, does it read both still? REPOSITORY R99 KDE

D26891: Upgrade theme to Breeze GTK on startup

gikari added a comment. @meven wrote: > What if users have a different default theme set on first launch? I would suggest to read the current theme instead of hardcoding Breeze. But I do not know where the information about the default GTK theme is located, so I do not know what to

D26891: Upgrade theme to Breeze GTK on startup

gikari updated this revision to Diff 74386. gikari marked 2 inline comments as done. gikari added a comment. Remove redundant theme update on startup REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26891?vs=74382=74386 BRANCH

D26891: Upgrade theme to Breeze GTK on startup

gikari added inline comments. INLINE COMMENTS > fvogt wrote in gtkconfig.cpp:207 > Now those two aren't needed anymore? Hm, yeah. Actually I think it is redundant to replace theme configuration on each start. It would make sense, if it was about syncing the settings, but since GTK theme is

D26891: Upgrade theme to Breeze GTK on startup

fvogt added inline comments. INLINE COMMENTS > gtkconfig.cpp:207 > setEnableAnimations(); > +setDefaultGtk2Theme(); > +setDefaultGtk3Theme(); Now those two aren't needed anymore? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To: