D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir added a comment. In D27518#643502 , @sitter wrote: > My point is that this diff adds kguiaddons as a link library but doesn't actually use any symbol, so it may as well not be a link library (or something ought to call some function

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

sitter added a comment. My point is that this diff adds kguiaddons as a link library but doesn't actually use any symbol, so it may as well not be a link library (or something ought to call some function of kguiaddons so it actually links it) ;) REPOSITORY R124 System Settings REVISION

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir added a comment. In D27518#643466 , @sitter wrote: > FYI linking a library without actually using any symbols is not going to do anything in practice because many distros link with --as-needed which undoes unnecessary linking. also

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

sitter added a comment. FYI linking a library without actually using any symbols is not going to do anything in practice because many distros link with --as-needed which undoes unnecessary linking. also see https://markmail.org/message/m3mdrsfgxoyfjtte REPOSITORY R124 System Settings

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R124:0be65944f311: If KHelpCenter isnt available fallback to opening doc at docs.kde.org (authored by ahmadsamir). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76447. ahmadsamir added a comment. target_link_libraries() KGuiAddons in the sysetmsettings5 target REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27518?vs=76355=76447 BRANCH l-khelp (branched from

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

apol added a comment. In D27518#617439 , @ahmadsamir wrote: > In D27518#617038 , @apol wrote: > > > Makes sense. Have you tested that this works? You should probably pass KF5::GuiAddons to the

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76355. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. target_link_libraries() KGuiAddons REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27518?vs=76266=76355 BRANCH l-khelp

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir added a comment. In D27518#617038 , @apol wrote: > Makes sense. Have you tested that this works? You should probably pass KF5::GuiAddons to the target_link_libraries as well. I tested a good number of the KCMs, and it seems to

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

apol added a comment. Makes sense. Have you tested that this works? You should probably pass KF5::GuiAddons to the target_link_libraries as well. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D27518 To: ahmadsamir, #plasma, apol Cc: plasma-devel, Orage,

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76266. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. find_package() KGuiAddons REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27518?vs=76265=76266 BRANCH l-khelp (branched

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir added a comment. I wonder how to make systemsettings depend on KGuiAddons (if that's needed here)? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D27518 To: ahmadsamir, #plasma, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76265. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Change BUG: REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27518?vs=76259=76265 BRANCH l-khelp (branched from master)

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76259. ahmadsamir retitled this revision from "Only enable the "Help" button if khelpcenter is available" to "If KHelpCenter isn't available fallback to opening doc at docs.kde.org". ahmadsamir edited the summary of this revision. ahmadsamir removed a