This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dceb791c0779: WebShortcuts Runner: Refactor foreach,
remove unnecessary method (authored by alex).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
alex updated this revision to Diff 78338.
alex added a comment.
Coding style: put space before {
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27566?vs=76144=78338
BRANCH
arcpatch-D27566
REVISION DETAIL
https://phabricator.kde.org/D27566
broulik accepted this revision.
broulik added inline comments.
INLINE COMMENTS
> webshortcutrunner.cpp:79
> const int delimIndex = term.indexOf(m_delimiter);
> -if (delimIndex == term.length() - 1)
> +if (delimIndex == -1 || delimIndex == term.length() - 1){
> return;
alex added a comment.
Ping @broulik :-)
REPOSITORY
R120 Plasma Workspace
BRANCH
webshortcuts_cleanup (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27566
To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
Seems good to me, wait for @broulik review
REPOSITORY
R120 Plasma Workspace
BRANCH
webshortcuts_cleanup (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27566
To:
alex updated this revision to Diff 76144.
alex added a comment.
Adjust comment
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27566?vs=76142=76144
BRANCH
webshortcuts_cleanup (branched from master)
REVISION DETAIL
alex created this revision.
alex added reviewers: ngraham, broulik, meven, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
The foreach has been refactored and the loadSyntaxes method gets now called
