D27576: Kill Runner: Move config keys to new file

2020-05-10 Thread Alexander Lohnau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:63deb6a0125b: Kill Runner: Move config keys to new file 
(authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27576?vs=79224=82462

REVISION DETAIL
  https://phabricator.kde.org/D27576

AFFECTED FILES
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-05-10 Thread Méven Car 
meven accepted this revision.
meven added a comment.


  In D27576#659971 , @alex wrote:
  
  > @meven and others, may I ship this?
  
  
  Yep ship it, it is low risk.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576_1

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-04-29 Thread Alexander Lohnau 
alex added a comment.


  @meven and others, may I ship this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576_1

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-04-03 Thread Alexander Lohnau 
alex added a comment.


  Thanks! 
  
  And may I ship this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576_1

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-04-03 Thread Alexander Lohnau 
alex updated this revision to Diff 79224.
alex added a comment.


  Fix wrong username

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27576?vs=78137=79224

BRANCH
  arcpatch-D27576_1

REVISION DETAIL
  https://phabricator.kde.org/D27576

AFFECTED FILES
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-04-02 Thread David Edmundson 
davidedmundson added a comment.


  > Quick question: I just realized that I committed the second commit with a 
wrong username (this will get rejected when I try to land the patch).
  
  git config user.name
  
  then
  
  git commit --amend --author "Your Name "

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-04-02 Thread Alexander Lohnau 
alex added a comment.


  Quick question: I just realized that I committed the second commit with a 
wrong username (this will get rejected when I try to land the patch).
  What is the best way to solve this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-03-21 Thread Alexander Lohnau 
alex marked an inline comment as done.
alex added inline comments.

INLINE COMMENTS

> meven wrote in killrunner.cpp:65
> You can use the enum as default value here I guess : Sort::NONE

What you suggested is not possible, because the enum is not declared as an enum 
qobject and declaring it just for this one occurrence seems unnecessary to me 
:-).
But using an int cast of the default value makes the code more readable.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D27576

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-03-21 Thread Alexander Lohnau 
alex updated this revision to Diff 78137.
alex added a comment.


  Use cast for the default value

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27576?vs=76172=78137

BRANCH
  arcpatch-D27576

REVISION DETAIL
  https://phabricator.kde.org/D27576

AFFECTED FILES
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-03-20 Thread Méven Car 
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Minor nitpick
  So the code basically extracts from KillRunnerConfigForm the Config constants.

INLINE COMMENTS

> killrunner.cpp:65
>  
> -m_sorting = (KillRunnerConfig::Sort) grp.readEntry(CONFIG_SORTING, 0);
> +m_sorting = (Sort) grp.readEntry(CONFIG_SORTING, 0);
>  QList syntaxes;

You can use the enum as default value here I guess : Sort::NONE

REPOSITORY
  R120 Plasma Workspace

BRANCH
  killrunner_config_refactoring

REVISION DETAIL
  https://phabricator.kde.org/D27576

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27576: Kill Runner: Move config keys to new file

2020-02-22 Thread Alexander Lohnau 
alex created this revision.
alex added reviewers: davidedmundson, ngraham, broulik, meven, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The config keys/sorting enum have been moved to a new file, before this the 
runner included the header of the config class.
  This patch originated from https://phabricator.kde.org/D27513, but it was 
requested to split it up into separate patches.

TEST PLAN
  Should compile.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  killrunner_config_refactoring

REVISION DETAIL
  https://phabricator.kde.org/D27576

AFFECTED FILES
  runners/kill/config_keys.h
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart