D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

2020-02-23 Thread Stefan Brüns 
bruns updated this revision to Diff 76253.
bruns added a comment.


  ignoreMountPoint -> ignoredMountPoint
  whitespace

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27611?vs=76251=76253

REVISION DETAIL
  https://phabricator.kde.org/D27611

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h

To: bruns, #baloo, ngraham
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

2020-02-23 Thread Stefan Brüns 
bruns added a comment.


  In D27611#616556 , @usta wrote:
  
  > 2 Question : 
  >  1- isnt that method should be const'ified ?
  
  
  Its not a member function ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27611

To: bruns, #baloo, ngraham
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

2020-02-23 Thread Ömer Fadıl Usta 
usta added a comment.


  2 Question : 
  1- isnt that method should be const'ified ? 
  2- also its name will be much better isIgnoreableMountPoint (or something can 
be more understandable
  that it will just return true or false ) becase right now it looks like
  "ignore that mount point"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27611

To: bruns, #baloo, ngraham
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

2020-02-23 Thread Stefan Brüns 
bruns updated this revision to Diff 76251.
bruns added a comment.


  move out of class

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27611?vs=76249=76251

REVISION DETAIL
  https://phabricator.kde.org/D27611

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

2020-02-23 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Instead of negating the logic values in several places, just invert
  the logic.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27611

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h

To: bruns, #baloo, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart