D27838: Port to new QML Connections syntax

2020-03-05 Thread David Edmundson 
davidedmundson added a comment.


  Relevant temporary "fix": 
https://codereview.qt-project.org/c/qt/qtdeclarative/+/293011

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27838

To: jbbgameich, #frameworks, apol
Cc: davidedmundson, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D27838: Port to new QML Connections syntax

2020-03-04 Thread Aleix Pol Gonzalez 
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Yes, can't be done until 5.14 is required in frameworks.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D27838

To: jbbgameich, #frameworks, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27838: Port to new QML Connections syntax

2020-03-04 Thread Jonah Brüchert 
jbbgameich updated this revision to Diff 76950.
jbbgameich added a comment.


  Fix syntax error

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27838?vs=76949=76950

BRANCH
  5.15-connections-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27838

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Menu.qml

To: jbbgameich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27838: Port to new QML Connections syntax

2020-03-04 Thread Jonah Brüchert 
jbbgameich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Fixes deprecation warnings with Qt 5.15

TEST PLAN
  No deprecations warnings, everything still works

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  5.15-connections-syntax (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27838

AFFECTED FILES
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Menu.qml

To: jbbgameich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart