D28072: [GTK Config] Apply color scheme to GTK3 applications

This revision was automatically updated to reflect the committed changes. Closed by commit R99:a5d4ddb3b1a2: [GTK Config] Apply color scheme to GTK3 applications (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. So, is it ok to land? If so, approve please. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n,

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. If the code looks good to you, let's ship it. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n,

D28072: [GTK Config] Apply color scheme to GTK3 applications

ndavis added a comment. Works for me. @ngraham, perhaps you forgot to restart `kded5`? I forgot that at first. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ndavis, ngraham, davidre,

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. I did. I followed your test plan exactly. :/ REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. Hm, this is bizarre. I've tested once again and now the bug I mentioned before is gone. @ngraham Did you launch system settings (colors section) **after applying** D28070 to plasma-desktop? Without that patch it won't work

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. No. :( I feel like I'm doing something really stupid here to make nothing work... REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre,

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638800 , @gikari wrote: > I also noticed a **dynamic** recoloration bug: it doesn't work if the app is launched with the color scheme, that it was using in the previous launch. To make it work I have to change

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Still doesn't work: gnome-chess --gtk-module /home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so Gtk-Message: 08:49:51.962: Failed to load module "colorreload-gtk-module" In D28072#643694

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#643693 , @ngraham wrote: > Still doesn't work for me: > > gnome-chess --gtk-module /home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so > Gtk-Message: 08:49:51.962: Failed to load

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Still doesn't work for me: gnome-chess --gtk-module /home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so Gtk-Message: 08:49:51.962: Failed to load module "colorreload-gtk-module" REPOSITORY R99 KDE Gtk Configuration Tool BRANCH

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 79263. gikari added a comment. - Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28072?vs=78823=79263 BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Haven't tried yet, sorry. I'll give it another shot today. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n,

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. @ngraham Did you manage to load the recoloration module into the GTK app by one or another way? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre,

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638514 , @ngraham wrote: > Same error about not being able to find the module. Sorry for not being clear. Does the specified path contain (`/home/nate/kde/usr/lib64/gtk-3.0/`) `modules` directory with

D28072: [GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#638514 , @ngraham wrote: > Same error about not being able to find the module. Sorry for not being clear. You can provide a full path to the library instead of letting GTK do name to library resolution.

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Same error about not being able to find the module. Sorry for not being clear. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre, plasma-devel,

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638356 , @ngraham wrote: > The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but nonetheless there is no effect. :( Is the GTK application throwing the same error, that the module is

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but nonetheless there is no effect. :( REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham,

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638170 , @ngraham wrote: > Hmm, when following those instructions, I get the following console error: > > Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module" > > > And the color

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#638173 , @cblack wrote: > GTK™ isn't too fond of trying to load stuff from outside the standard directories. How can this be fixed? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Well this is kind of a problem then since we need to support development builds to a nonstandard install prefix. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc:

D28072: [GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#638170 , @ngraham wrote: > Hmm, when following those instructions, I get the following console error: > > Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module" > > > And the color

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Hmm, when following those instructions, I get the following console error: Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module" And the color scheme doesn't change. The `colorreload-gtk3-module` target did get built, and it installed a

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 78823. gikari marked an inline comment as done. gikari added a comment. - Rebase on master - Add recoloration module check REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28072?vs=77860=78823 BRANCH

D28072: [GTK Config] Apply color scheme to GTK3 applications

davidre added a comment. It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: davidre,