D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:a5d4ddb3b1a2: [GTK Config] Apply color scheme to GTK3 
applications (authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=79263=80166

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma, ngraham
Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  So, is it ok to land? If so, approve please.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  If the code looks good to you, let's ship it.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Noah Davis]

ndavis added a comment.


  Works for me. @ngraham, perhaps you forgot to restart `kded5`? I forgot that 
at first.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  I did. I followed your test plan exactly. :/

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  Hm, this is bizarre. I've tested once again and now the bug I mentioned 
before is gone.
  
  @ngraham Did you launch system settings (colors section) **after applying** 
D28070  to plasma-desktop? Without that 
patch it won't work possibly due to conflicts.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  No. :(
  
  I feel like I'm doing something really stupid here to make nothing work...

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638800 , @gikari wrote:
  
  > I also noticed a **dynamic** recoloration bug: it doesn't work if the app 
is launched with the color scheme, that it was using in the previous launch. To 
make it work I have to change color scheme and relaunch the app. The app 
therefore changes its color scheme to a new one and it is now reacting to color 
scheme change properly (i.e. changes it without restart).
  
  
  Can you reproduce this behavior?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  Still doesn't work:
  
gnome-chess --gtk-module 
/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so
Gtk-Message: 08:49:51.962: Failed to load module "colorreload-gtk-module"
  
  
  
  In D28072#643694 , @gikari wrote:
  
  > In D28072#643693 , @ngraham 
wrote:
  >
  > > Still doesn't work for me:
  > >
  > >   gnome-chess --gtk-module 
/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so
  > >   Gtk-Message: 08:49:51.962: Failed to load module 
"colorreload-gtk-module"
  > >
  >
  >
  > Actually the specified module is loaded. The error message comes from the 
module specified in the settings.ini.
  >
  > If it weren't the message would be something like this (i.e. mentioning 
absolute module path):
  >
  >   Gtk-Message: 17:56:18.012: Failed to load module 
"/home/gikari/kde/usr/lib/gtk-3.0/modules/libcolorreload-gtkd-module.so"
  >
  >
  > Check the recoloration - does it work?
  
  
  No. :(

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#643693 , @ngraham wrote:
  
  > Still doesn't work for me:
  >
  >   gnome-chess --gtk-module 
/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so
  >   Gtk-Message: 08:49:51.962: Failed to load module "colorreload-gtk-module"
  >
  
  
  Actually the specified module is loaded. The error message comes from the 
module specified in the settings.ini.
  
  If it weren't the message would be something like this (i.e. mentioning 
absolute module path):
  
Gtk-Message: 17:56:18.012: Failed to load module 
"/home/gikari/kde/usr/lib/gtk-3.0/modules/libcolorreload-gtkd-module.so"
  
  Check the recoloration - does it work?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  Still doesn't work for me:
  
gnome-chess --gtk-module 
/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so
Gtk-Message: 08:49:51.962: Failed to load module "colorreload-gtk-module"

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari updated this revision to Diff 79263.
gikari added a comment.


  - Rebase on master

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=78823=79263

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  Haven't tried yet, sorry. I'll give it another shot today.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  @ngraham Did you manage to load the recoloration module into the GTK app by 
one or another way?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638514 , @ngraham wrote:
  
  > Same error about not being able to find the module. Sorry for not being 
clear.
  
  
  Does the specified path contain (`/home/nate/kde/usr/lib64/gtk-3.0/`) 
`modules` directory with the `libcolorreload-gtk-module.so` file?
  If there it is, try launching GTK app with:
  
gtk-app --gtk-module 
/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so
  
  The parameter must be **absolute** path.
  
  In D28072#638515 , @cblack wrote:
  
  > You can provide a full path to the library instead of letting GTK do name 
to library resolution.
  
  
  Yes, you can, but that's inconvenient. According to this 
 you can specify 
`GTK_PATH` environment variable, so that GTK knows where to search for modules. 
It works for me at least.
  
  I also noticed a **dynamic** recoloration bug: it doesn't work if the app is 
launched with the color scheme, that it was using in the previous launch. To 
make it work I have to change color scheme and relaunch the app. The app 
therefore changes its color scheme to a new one and it is now reacting to color 
scheme change properly (i.e. changes it without restart).

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Carson Black]

cblack added a comment.


  In D28072#638514 , @ngraham wrote:
  
  > Same error about not being able to find the module. Sorry for not being 
clear.
  
  
  You can provide a full path to the library instead of letting GTK do name to 
library resolution.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  Same error about not being able to find the module. Sorry for not being clear.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638356 , @ngraham wrote:
  
  > The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but 
nonetheless there is no effect. :(
  
  
  Is the GTK application throwing the same error, that the module is not found, 
or recoloration does not work?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but 
nonetheless there is no effect. :(

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638170 , @ngraham wrote:
  
  > Hmm, when following those instructions, I get the following console error:
  >
  >   Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module"
  >
  >
  > And the color scheme doesn't change. The `colorreload-gtk3-module` target 
did get built, and it installed a shared library to 
`/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so`
  
  
  Try `export GTK_PATH='$PREFIX/kde/usr/lib/gtk-3.0/' ` before launching app. 
This should make module to load.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#638173 , @cblack wrote:
  
  > GTK™ isn't too fond of trying to load stuff from outside the standard 
directories.
  
  
  How can this be fixed?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  Well this is kind of a problem then since we need to support development 
builds to a nonstandard install prefix.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Carson Black]

cblack added a comment.


  In D28072#638170 , @ngraham wrote:
  
  > Hmm, when following those instructions, I get the following console error:
  >
  >   Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module"
  >
  >
  > And the color scheme doesn't change. The `colorreload-gtk3-module` target 
did get built, and it installed a shared library to 
`/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so`
  
  
  GTK™ isn't too fond of trying to load stuff from outside the standard 
directories.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Nathaniel Graham]

ngraham added a comment.


  Hmm, when following those instructions, I get the following console error:
  
Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module"
  
  And the color scheme doesn't change. The `colorreload-gtk3-module` target did 
get built, and it installed a shared library to 
`/home/nate/kde/usr/lib64/gtk-3.0/modules/libcolorreload-gtk-module.so`

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari updated this revision to Diff 78823.
gikari marked an inline comment as done.
gikari added a comment.


  - Rebase on master
  - Add recoloration module check

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=77860=78823

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[David Redondo]

davidre added a comment.


  It seems it is possible to do this (removing stuff from the data engine) 
after all. I will try to work on this in the next time

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart