D28262: [applets/analog-clock] Optional minute hand

[Nathaniel Graham]

ngraham added a comment.


  Heh. Thanks anyway! And now you have a dev environment set up so your next 
patch will be easier. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma, ngraham
Cc: broulik, ngraham, aloiseau, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Anthony Loiseau]

aloiseau abandoned this revision.
aloiseau added a comment.


  No problem :) If someone find it useful, then he/she will find it there and 
can apply it locally in its ~/.local/share folder.
  Note for anyone wanting to apply this patch locally in the future: hiding 
minute marks around the clock (keeping only hour marks) is the next funny step!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma, ngraham
Cc: broulik, ngraham, aloiseau, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I'm not sure I think this makes sense, sorry. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma, ngraham
Cc: broulik, ngraham, aloiseau, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Anthony Loiseau]

aloiseau added a comment.


  In D28262#634715 , @broulik wrote:
  
  > > I can not find a kcfg file in this applet to simply extend
  >
  > In applets it's the `config.xml` you edited, so from a technical POV patch 
is good. Not sure this option is very useful, however.
  
  
  Ok for the technical POV, thanks. I very understand the usefulness question 
such option can raise, letting the community integrating it or not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma
Cc: broulik, ngraham, aloiseau, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Kai Uwe Broulik]

broulik added a comment.


  > I can not find a kcfg file in this applet to simply extend
  
  In applets it's the `config.xml` you edited, so from a technical POV patch is 
good. Not sure this option is very useful, however.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma
Cc: broulik, ngraham, aloiseau, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Anthony Loiseau]

aloiseau added a comment.


  Thanks Nathaniel for your feedbacks.
  
  About your technical comment, I can not find a kcfg file in this applet to 
simply extend. I will have a closer look to existing kcfg files and create one 
for analog clock (next weekend I guess)
  
  About the conceptual comment, you are right: clocks without minute hand are 
not common :)
  I have a real one since few years after minute hand gets broken and removed. 
I finally found the result very ergonomic: faster to read and accurate enough, 
less disturbing / "attractive" (no need to take a look at it every five 
minutes).
  This is more common when it comes to watches, under the name "slow watches" 
which features a single hand for a full-day 24-hour circle (mid-day on top and 
mid-night on bottom). Since I have no doubt about the morning or the evening, I 
find the halfway with a 12-hours circle still useful and use it daily.
  
  Maybe in the future I will make a proposal for a more real slow clock option 
(24-hours circle) if someone find it useful.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma
Cc: ngraham, aloiseau, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Friedrich W. H. Kossebau]

kossebau resigned from this revision.
kossebau added a comment.


  Resigning, due to currently not having time for Plasma development.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma
Cc: ngraham, aloiseau, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Nathaniel Graham]

ngraham edited reviewers, added: VDG, Plasma; removed: Plasma: Workspaces.
ngraham added a comment.


  Thanks for the patch, Anthony!
  
  Technical comment: you need to update the kcfg file too, to add a definition 
of the new option.
  
  Conceptual/UI comment: do you think you could explain the use case for 
showing an analog clock without a minute hand? I don't think I've ever seen any 
real-world analog clocks without minute hands.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, kossebau, #vdg, #plasma, #plasma_workspaces
Cc: ngraham, aloiseau, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Anthony Loiseau]

aloiseau created this revision.
aloiseau added reviewers: Plasma: Workspaces, kossebau.
aloiseau added a project: Plasma: Workspaces.
Herald edited projects, added Plasma; removed Plasma: Workspaces.
Herald added a subscriber: plasma-devel.
aloiseau requested review of this revision.

REVISION SUMMARY
  Add a configuration option to hide minute hand, the same way second hand can 
already be hidden.
  
  Those two options are independent, letting user hide minute hand alone.
  

  
  Clock refresh interval is not modified. It still refreshes every 30 seconds 
when second hand is hidden, even when hour hand is the only visible one. Having 
this interval computed from both hiddable hands would make its computation less 
readable for a minor CPU benefit.

TEST PLAN
  - Add an Analog Clock to your Plasma wallpaper
  - Go to its setting
  - Deselect new "Show minute hand" option
  - Apply
  
  Minute hand is then hidden from Analog Clock widget.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

AFFECTED FILES
  applets/analog-clock/contents/config/main.xml
  applets/analog-clock/contents/ui/analogclock.qml
  applets/analog-clock/contents/ui/configGeneral.qml

To: aloiseau, #plasma_workspaces, kossebau
Cc: aloiseau, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart