D28275: skip over supposed network shares that aren't
This revision was automatically updated to reflect the committed changes. Closed by commit R102:4847c9e2fed2: skip over supposed network shares that arent (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28275?vs=78442=78472 REVISION DETAIL https://phabricator.kde.org/D28275 AFFECTED FILES Modules/samba/smbmountmodel.cpp To: sitter, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28275: skip over supposed network shares that aren't
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops! REPOSITORY R102 KInfoCenter BRANCH smb-type-check REVISION DETAIL https://phabricator.kde.org/D28275 To: sitter, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D28275: skip over supposed network shares that aren't
sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY we explicitly request listFromType(Solid::DeviceInterface::NetworkShare) but apparently still can get devices that aren't actually of that type. add an explicit type check to guard against bogus shares coming out of listFromType. CCBUG: 419220 TEST PLAN mount an overlay (I am guessing that's what the problem with kubuntu is), observe no crash on init REPOSITORY R102 KInfoCenter BRANCH smb-type-check REVISION DETAIL https://phabricator.kde.org/D28275 AFFECTED FILES Modules/samba/smbmountmodel.cpp To: sitter, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
