D28276: only add devices to the smb mount model that are network shares

2020-03-25 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R102:23d52fa33394: only add devices to the smb mount model that are network shares (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28276?vs=7844

D28276: only add devices to the smb mount model that are network shares

2020-03-25 Thread Harald Sitter
sitter added a comment. In D28276#634264 , @broulik wrote: > This is because the device monitor emits all devices, not the query returning unwanted devices? Yep connect(Solid::DeviceNotifier::instance(), &Solid::DeviceNotifier::de

D28276: only add devices to the smb mount model that are network shares

2020-03-25 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. This is because the device monitor emits all devices, not the query returning unwanted devices? REPOSITORY R102 KInfoCenter BRANCH smb-type-check2 REVISION DETAIL https://phabrica

D28276: only add devices to the smb mount model that are network shares

2020-03-25 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously we'd add all devices which would then cause a crash when trying to access them ->as() b