D28544: RecentDocuments Runner: Cleanup and formatting

2020-06-02 Thread Méven Car
meven added a comment. Well @alex https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 was merged, so if you are still up to do it, now is a good time to rebase your changes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28544 To: alex,

D28544: RecentDocuments Runner: Cleanup and formatting

2020-06-01 Thread Alexander Lohnau
alex abandoned this revision. alex added a comment. Will continue on gitlab REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28544 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28544: RecentDocuments Runner: Cleanup and formatting

2020-05-29 Thread Méven Car
meven added a comment. To rebase after https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 lands REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28544 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage,

D28544: RecentDocuments Runner: Cleanup and formatting

2020-04-04 Thread Alexander Lohnau
alex added a comment. I didn't knew this patch existed and that it introduces coneptual changes. This is just a patch with smaller improvements/cleanup. Because of this I suggest waiting for your patch to be merged and than rebasing . REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28544: RecentDocuments Runner: Cleanup and formatting

2020-04-04 Thread Méven Car
meven added a comment. Regarding the recentdocument krunner, I have a patch to make it rely on kactivity data : D26111 . It has been waiting for review of a while. This patch will introduce a lot of conflict, but I am ok either way, if this one get

D28544: RecentDocuments Runner: Cleanup and formatting

2020-04-03 Thread Alexander Lohnau
alex updated this revision to Diff 79244. alex added a comment. Change import REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28544?vs=79243=79244 BRANCH recentdocuments_cleanup (branched from master) REVISION DETAIL

D28544: RecentDocuments Runner: Cleanup and formatting

2020-04-03 Thread Alexander Lohnau
alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik, meven, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY - Instead of early returning in the match method if the list of