D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79973. cblack added a comment. Add configuration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79972=79973 BRANCH arcpatch-D28627 REVISION DETAIL https://phabricator.kde.org/D28627 AFFECTED FILES

D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79972. cblack added a comment. Filter by screen REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79970=79972 BRANCH arcpatch-D28627 REVISION DETAIL https://phabricator.kde.org/D28627 AFFECTED FILES

D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79970. cblack added a comment. Fix errors REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79969=79970 BRANCH arcpatch-D28627 REVISION DETAIL https://phabricator.kde.org/D28627 AFFECTED FILES

D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79969. cblack added a comment. Refactor to state/transitions and don't render two FrameSvgItems at once REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79968=79969 BRANCH arcpatch-D28627 REVISION

D28627: WIP: Made panel opaque on maximized window

cblack updated this revision to Diff 79968. cblack added a comment. Use D28784 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79494=79968 BRANCH arcpatch-D28627 REVISION DETAIL

D28627: WIP: Made panel opaque on maximized window

niccolove added a comment. I have a question though: we ship the pager widget in the panel that does the same by default. Wouldn't that have the same efficiency impact, if not even more? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: niccolove,

D28627: WIP: Made panel opaque on maximized window

ngraham added a comment. In D28627#644050 , @davidedmundson wrote: > We only want to: > > - check when isMaximised potentially changes It would also be nice to turn off transparency for a panel that has a window tiled against its

D28627: WIP: Made panel opaque on maximized window

davidedmundson added a comment. > or is the window.isMaximized implementation bad in win? The problematic part of this patch is that whenever any property on any window changes we're checking all items. We only want to: - check when isMaximised potentially changes - only

D28627: WIP: Made panel opaque on maximized window

niccolove added a comment. > You're rendering a transparent panel. we're still even blurring the background very expensively. And then we're drawing something on top. That's very wasteful. > We're also mixing up shadows from one SVG with the output of another. Right. Originally I

D28627: WIP: Made panel opaque on maximized window

davidedmundson requested changes to this revision. davidedmundson added a comment. Ok, so the logic is - the goal is to blend in. If you're not showing the desktop, you can't blend in to it. I can at least understand the thought process. --- Code wise, this needs a lot of work.

D28627: WIP: Made panel opaque on maximized window

ngraham added a comment. Yeah plasmoid pop-ups should probably also be opaque when the panel is opaque, good call. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: niccolove, #plasma Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n,

D28627: WIP: Made panel opaque on maximized window

niccolove added a comment. Thanks Nate for explaining. Couple of things that hit my mind: - Plasmoids should also be opaque, to be fully integrated: F8223607: Screenshot_20200407_191202.png Should I have very similiar code in the applet

D28627: WIP: Made panel opaque on maximized window

ngraham added a comment. In D28627#643038 , @davidedmundson wrote: > Why? See the discussion in D28353 . Essentially, we ran into a design issue whereby increasing the transparency of the panel

D28627: WIP: Made panel opaque on maximized window

davidedmundson added a comment. Why? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: niccolove, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D28627: WIP: Made panel opaque on maximized window

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY The idea is to offer an option, possibly default, to make the panel opaque when a window is maximized on the same screen.