D29140: Show POTD in lock screen

ngraham added a comment. Done and landed! You can close this now. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, davidre, broulik Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29140: Show POTD in lock screen

guoyunhe added a comment. Also in KDE Invent. https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/3 Can someone review it? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, davidre, broulik Cc: davidre, ngraham,

D29140: Show POTD in lock screen

ngraham added a comment. @davidre is this better now? Also @broulik and other #plasma people may want to review. Finally, you might consider moving this to GitLab for greater visibility. REPOSITORY R114 Plasma Addons REVISION DETAIL

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82996. guoyunhe added a comment. No delete engine and watcher REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82994=82996 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED

D29140: Show POTD in lock screen

davidre added inline comments. INLINE COMMENTS > kded_potd.cpp:25 > +delete engine; > +delete watcher; > +} Don't need to delete watcher because you constructed it with `this` as parent. https://doc.qt.io/qt-5/objecttrees.html For the engine don't delete it because you don't have the

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82994. guoyunhe added a comment. Remove unused slots REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82993=82994 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82993. guoyunhe added a comment. Fix leaks REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82821=82993 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Show POTD in lock screen

davidre added a comment. Flickr works here F8325269: Screenshot_20200516_095930.png > For the leaks, I really have no idea. (also asked some friends but no help) C++ isn't my primary programming language. If you can share some

D29140: Show POTD in lock screen

guoyunhe added a comment. Maybe it is some unknown Qt bug. You can try set wallpaper as Flickr POTD and check if you have `~/.cache/plasmashell/plasma_engine_potd/flickr` saved. Anyway, for photos, JPEG makes more sense than PNG. For the leaks, I really have no idea. (also asked some

D29140: Show POTD in lock screen

davidre added a comment. I don't get how saving as a png fails if we have the image as QImage. INLINE COMMENTS > kded_potd.cpp:9 > +{ > +consumer = new Plasma::DataEngineConsumer(); > +engine = consumer->dataEngine(QStringLiteral("potd")); still leaks > kded_potd.cpp:28 > + */ >

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82821. guoyunhe added a comment. Code improvement REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82819=82821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82819. guoyunhe marked 9 inline comments as done. guoyunhe added a comment. Fix small issues REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82635=82819 BRANCH master REVISION DETAIL

D29140: Show POTD in lock screen

guoyunhe marked 9 inline comments as done. guoyunhe added inline comments. INLINE COMMENTS > davidre wrote in CMakeLists.txt:44 > Seems unused? It is necessary for the KDED module. Without it, the compilation fails. > davidre wrote in CMakeLists.txt:68 > unrelated Will revert. > davidre

D29140: Show POTD in lock screen

davidre added a comment. I fail to see what the kded module actually does. Or is it the case that simply requesting the data from the engine causes it to cache the image on disk? Maybe that should be documented. INLINE COMMENTS > CMakeLists.txt:44 > CoreAddons > +DBusAddons >