D29333: Don't show an empty error dialog when canceling the sync password prompt

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Looked into it and concluded that PolKit/Kauth are... special.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D29333

To: ngraham, filipf, davidedmundson, #plasma
Cc: broulik, mthw, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29333: Don't show an empty error dialog when canceling the sync password prompt

[Nathaniel Graham]

ngraham added a comment.


  Discover has the same issue. I guess I should look into fixing KAuth or 
Polkit or whatever is responsible for this.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D29333

To: ngraham, filipf, davidedmundson, #plasma
Cc: broulik, mthw, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29333: Don't show an empty error dialog when canceling the sync password prompt

[Filip Fila]

filipf added a comment.


  Yeah, this is also an issue when clicking cancel on a password prompt in 
sddm-kcm's GHNS and when clicking Reset in the Advanced tab. And when canceling 
theme deletion an empty inline message pops up :/
  
  We could work around all four though. I'm of the opinion that it's better to 
have a workaround if waiting for a proper fix will take time. I also agree with 
@ngraham that no notification is needed when an auth dialog is canceled.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D29333

To: ngraham, filipf, davidedmundson, #plasma
Cc: broulik, mthw, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29333: Don't show an empty error dialog when canceling the sync password prompt

[Kai Uwe Broulik]

broulik added a comment.


  I would like KAuth or Polkit to be fixed to properly report user canceling

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D29333

To: ngraham, filipf, davidedmundson, #plasma
Cc: broulik, mthw, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29333: Don't show an empty error dialog when canceling the sync password prompt

[Nathaniel Graham]

ngraham added a comment.


  In D29333#661119 , @mthw wrote:
  
  > Now there is no error message at all. Instead of removing the dialog, 
shouldn't there be a message added to inform the user, that they have to enter 
a password to do the action and also that no changes were made? Something like 
Kate does when you try to save changes to a file that requires you to enter a 
password and you don't enter it.
  
  
  This change only suppresses the dialog when the error message returned from 
the job is empty. If you cancel the password dialog, I'm not sure any extra 
notification is needed. Canceling an operation is pretty self-explanatory in 
the user's mind.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D29333

To: ngraham, filipf, davidedmundson, #plasma
Cc: mthw, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29333: Don't show an empty error dialog when canceling the sync password prompt

[Matej Mrenica]

mthw added a comment.


  Now there is no error message at all. Instead of removing the dialog, 
shouldn't there be a message added to inform the user, that they have to enter 
a password to do the action and also that no changes were made? Something like 
Kate does when you try to save changes to a file that requires you to enter a 
password and you don't enter it.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D29333

To: ngraham, filipf, davidedmundson, #plasma
Cc: mthw, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29333: Don't show an empty error dialog when canceling the sync password prompt

[Nathaniel Graham]

ngraham updated this revision to Diff 81674.
ngraham added a comment.


  Fix comment (it's always something...)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29333?vs=81673=81674

BRANCH
  dont-badget-user-with-empty-error-dialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29333

AFFECTED FILES
  src/advancedconfig.cpp

To: ngraham, filipf, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29333: Don't show an empty error dialog when canceling the sync password prompt

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: filipf, davidedmundson, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 420855
  FIXED-IN: 5.18.5

TEST PLAN
  Click on the Sync button in the SDDM KCM and cancel the password dialog -> no 
empty
  error dialog shown now
  
  SYncing still works

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  dont-badget-user-with-empty-error-dialog (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29333

AFFECTED FILES
  src/advancedconfig.cpp

To: ngraham, filipf, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart